New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ArcBallCamera example #75
Conversation
2b11368
to
85cad80
Compare
85cad80
to
7e5015c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is great!
I went a bit more in detail on this, because I think this isn't too far from becoming a builtin feature -- especially when we relax the dependency on SceneGraph a bit :)
I would prefer to create just one ArcBallCamera object and nothing else, instead of having 3 objects:
By doing so, the last 2 objects will be private members of the ArcBall class. How do you think? |
Okay, maybe I'm diverging from simplicity of the example a bit too much already, but (to repeat myself) I'd like to have this easy to integrate for people who don't use / want to use the scenegraph. What about an Or if you're fine with the templated |
Hah, two-classes sounds good to me. We can have both of them, |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have time and want to make the merging easier on my side, could you:
- add a PNG 800x600 screenshot to
doc/arcball-camera.png
, without window borders please - add a
doc/arcball-camera.dox
doc page, showing the screenshot, listing key controls and having links to all source files? Similarly to what's in e.g.doc/fluidsimulation2d.dox
, doesn't need to be perfect, just putting most of the relevant content there :) - mention the new
WITH_
option indoc/building-examples.dox
- and enable the new
WITH_
option inpackage/ci/
in all*.bat
and*.sh
files, except thevulkan
,android
,emscripten
andios
ones, so I can see if it builds correctly on most platforms?
This will help me a lot, thanks much! 🙏
b362e5a
to
71cc4bc
Compare
Merged as 49a1bbe, thanks a lot! Especially thanks for the docs+CI push, that saved me quite some time. Docs now online here: https://doc.magnum.graphics/magnum/examples-arcball.html As I mentioned on Gitter, I made the |
Here is the arcball camera example :)
Brief Usage:
By mouse:
Keyboard shortcuts:
Enjoy.