Add accessor to the raw camera object, and replace thumbnail image#85
Closed
ttnghia wants to merge 3 commits intomosra:masterfrom
Closed
Add accessor to the raw camera object, and replace thumbnail image#85ttnghia wants to merge 3 commits intomosra:masterfrom
ttnghia wants to merge 3 commits intomosra:masterfrom
Conversation
I need to access the camera object in other examples.
mosra
reviewed
Jun 16, 2020
Owner
mosra
left a comment
mosra
left a comment
There was a problem hiding this comment.
Sure! Seems obvious, only one minor thing -- since the _camera is never null, I think a reference is better.
Co-authored-by: Vladimír Vondruš <mosra@centrum.cz>
Contributor
Author
|
Done :) |
ttnghia
changed the title
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to access the camera object in other examples.