New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to allow building on both Ubuntu 16.04 and 18.04. #5

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@matjam
Contributor

matjam commented May 27, 2018

As promised in mosra/magnum#248, here is a PR that will allow builds to work for both Ubuntu 18.04 and 16.04. Note that some of the changes are also to allow the build to work correctly in Launchpad, as it builds from a clean chroot every time dependencies may not be available.

@codecov-io

This comment has been minimized.

codecov-io commented May 27, 2018

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   19.24%   19.24%           
=======================================
  Files          35       35           
  Lines        1408     1408           
=======================================
  Hits          271      271           
  Misses       1137     1137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd4e56...d32d1b5. Read the comment docs.

@mosra

This comment has been minimized.

Owner

mosra commented May 31, 2018

Merged in 349675f, though without the explicit Corrade dependency (as we discussed on Gitter) -- if it turns out that the dependency is really needed on Launchpad, we can always add it later.

Thank you a lot! :)

@mosra mosra added this to TODO in Project management via automation May 31, 2018

@mosra mosra added this to the 2018.0c milestone May 31, 2018

@mosra mosra closed this May 31, 2018

Project management automation moved this from TODO to Done May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment