New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnum Player #6

Merged
merged 36 commits into from Oct 7, 2018

Conversation

@mosra
Owner

mosra commented Jul 27, 2018

This will become an extended version of the Viewer example with the end goal being an ability to view and play any 3D file you throw at it.

The initial goals, in scope of this PR, are:

  • Basic loading of scene files in scope that the Viewer example did
  • Camera controls better than the Viewer example (panning, depth-aware rotation -- might reuse mosra/magnum-examples#46)
  • Mention the app in Magnum's doc/utilities.dox
  • Mention the app in in the viewer example docs
  • Screenshot in the docs
  • Loading of animations and playing them back in a loop
    • Ability to pause them
    • Frame stepping
  • Web port
    • Upgrading the default web template
    • DPI awareness
    • Drag&drop instead of having a single hardcoded file
    • Ability to specify aspect ratio of the view Ability to full-size the view
    • Ability to D&D multiple files
  • Screenshot saving postponed
  • Resolve the issue with multiple lights changing alpha desired mask (the gltf alpha example fails)
  • Some default scene for the web view (animated cube at least) postponed
  • Figure out the depth issues postponed
  • Enable MSAA
  • Some better scene info (a modal) .. also cam count etc. postponed

@mosra mosra added this to the 2018.0c milestone Jul 27, 2018

@mosra mosra self-assigned this Jul 27, 2018

@mosra mosra added this to TODO in Project management via automation Jul 27, 2018

@mosra mosra referenced this pull request Jul 27, 2018

Closed

2018.10 release #265

56 of 56 tasks complete
@codecov-io

This comment has been minimized.

codecov-io commented Jul 27, 2018

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   18.68%   18.68%           
=======================================
  Files          35       35           
  Lines        1450     1450           
=======================================
  Hits          271      271           
  Misses       1179     1179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27da17...8778b3a. Read the comment docs.

@mosra mosra force-pushed the player branch from 61d1799 to c8507f2 Aug 3, 2018

@mosra mosra referenced this pull request Aug 4, 2018

Open

Complete animation support #101

17 of 44 tasks complete
</head>
<body>
<h1>Magnum glTF Player</h1>
<p style="max-width: 640px; text-align: center; margin-left: auto; margin-right: auto;">Drag &amp; drop your <tt>*.glb</tt> (or an <em>embedded</em> <tt>*.gltf</tt>) file into the grey rectange below to play it. Refresh the browser if it gets stuck. I'm not responsible for anything :P</p>

This comment has been minimized.

@Squareys

Squareys Aug 8, 2018

Contributor

"rectange" should be "rectangle" 😉

@mosra mosra force-pushed the player branch 2 times, most recently from 636eacc to 6000b10 Sep 1, 2018

@mosra mosra force-pushed the player branch 4 times, most recently from ea95753 to f0c755a Sep 14, 2018

@mosra mosra moved this from TODO to In Progress in Project management Sep 16, 2018

@mosra mosra added this to In progress in Player Sep 16, 2018

@mosra mosra force-pushed the player branch 3 times, most recently from b175dba to b1f561c Sep 16, 2018

@mosra mosra force-pushed the player branch from b1f561c to bd14193 Sep 25, 2018

@mosra mosra force-pushed the player branch from bd14193 to e47cce7 Oct 2, 2018

@mosra mosra changed the title from [WIP] Magnum Player to Magnum Player Oct 7, 2018

mosra added some commits Sep 11, 2018

package: enable the player app in all packages and CIs.
It needs Ui, which doesn't work on WebGL 1 / ES2.
player: "relayout" the UI on window size change.
Well, basically it's recreating it from scratch. Sorry, ugly, verbose
and slow. Needs to be done properly later.
player: depth-aware mouse interaction.
Reused from the Mouse Interaction example.
player: port the depth-aware mouse interaction to WebGL.
Again just a copy from the Mouse Interaction example.
player: try to use MSAA by default.
But only 2x on HiDPI and allow the users to override that.
player: support dropping multiple files.
Apparently hierarchy is not preserved with browser D&D so if a file in
subdir is not found, we try again using just the filename.
player: initialize the animation time destination.
Otherwise the animation time might not get displayed when the
destination random value would be matching animation progress.

@mosra mosra force-pushed the player branch from e47cce7 to 8778b3a Oct 7, 2018

@mosra mosra merged commit 8778b3a into master Oct 7, 2018

2 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Project management automation moved this from In Progress to Done Oct 7, 2018

Player automation moved this from In progress to Done Oct 7, 2018

@mosra mosra deleted the player branch Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment