New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor LibOvrIntegration API changes #4

Closed
mosra opened this Issue Jun 21, 2015 · 5 comments

Comments

Projects
2 participants
@mosra
Owner

mosra commented Jun 21, 2015

  • rename all getSomething() methods to something() for consistency (Hmd and SwapTextureSet classes)
  • return std::array<DualQuaternion, 2> from Hmd::getEyePoses()/Hmd::eyePoses() instead of std::unique_ptr, no need to do heap allocation in this case
  • rename LibOvrIntegration::LibOvrContext to just LibOvrIntegration::Context (also consistency, the header is already named like that)

cc @Squareys

@Squareys

This comment has been minimized.

Contributor

Squareys commented Jun 21, 2015

@mosra Do you want the first change only for those two classes? I know at least two more classes off the top of my head which would require some renaming aswell.

@mosra

This comment has been minimized.

Owner

mosra commented Jun 21, 2015

right... all of them, of course (I thought it were only these two)

@mosra

This comment has been minimized.

Owner

mosra commented Jul 24, 2015

Oh, this should have been closed for quite some time :)

@mosra mosra closed this Jul 24, 2015

@Squareys

This comment has been minimized.

Contributor

Squareys commented Jul 24, 2015

@mosra Yes, indeed, thank you! And thank you for cleaning up my code once again (in 3cd924e and following).

@mosra

This comment has been minimized.

Owner

mosra commented Jul 24, 2015

I needed to create compatibility branch for AppVeyor CI, the cleanup was just a byproduct :)

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment