ImGuiIntegration: don't use obsolete enum aliases #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would break for anyone using 1.87 and 1.88, since those enums only got renamed in 1.89 WIP: ocornut/imgui@fd408c9 Best solution I can think of is to use the new enums optionally behind |
sthalik
force-pushed
the
pr/imgui-obsolete-enum
branch
from
54871da to
557ebf7
Compare
This building newer ImGui with `IMGUI_DISABLE_OBSOLETE_FUNCTIONS`. Use `IMGUI_VERSION_NUM` to avoid breaking old versions (by @pezcode).
sthalik
force-pushed
the
pr/imgui-obsolete-enum
branch
from
557ebf7 to
6ad015e
Compare
Codecov ReportBase: 76.67% // Head: 76.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 76.67% 76.67%
=======================================
Files 21 21
Lines 973 973
=======================================
Hits 746 746
Misses 227 227
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to me because clangd chokes on the oversized ImGui header and reducing its size through
IMGUI_DISABLE_OBSOLETE_FUNCTIONShelps a bit.