New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup OvrIntegration issues #15

Merged
merged 19 commits into from Aug 15, 2016

Conversation

Projects
2 participants
@Squareys
Contributor

Squareys commented Jun 13, 2016

Hi @mosra !

I finally got around to cleaning up #13... sorry it took me so long. And sorry for the mess, some of the things I fixed were rather sloppy.

Regards, Jonathan.

PS: Take your time with the review, I will need to compile check the example still anyway, and this shouldn't be urgent in any way.

@@ -108,8 +103,6 @@ LayerQuad& LayerQuad::setQuadSize(const Vector2& size) {
return *this;
}
Compositor::Compositor() = default;

This comment has been minimized.

@mosra

mosra Jun 14, 2016

Owner

I would keep the constructor here, the class has heavy members (std::vector) and having the constructor inlined will increase compile time and binary size.

Error err;
err.type = ErrorType(info.Result);
strncpy(err.message, info.ErrorString, 512);

This comment has been minimized.

@mosra

mosra Jun 14, 2016

Owner

std::strncpy()?

@mosra

This comment has been minimized.

Owner

mosra commented Jun 14, 2016

Thanks a lot! 👍

I still saw mentions of the OVR API instead of the wrapped API in the error enum, can you look there also?

@Squareys Squareys force-pushed the Squareys:cleanup-ovr-integration branch from 5253cd4 to 6292ed7 Jul 15, 2016

@Squareys

This comment has been minimized.

Contributor

Squareys commented Jul 15, 2016

@mosra I addressed the new issues (de-inlined the Compositor constructor, referenced OvrIntegration types in errors enum and added the std::). This could possibly be good to go now :)

Regards, Squareys.

Squareys added some commits Jun 13, 2016

OvrIntegration: Cleanup naming of Session variables and parameters
Also: improve consistency of "HMD" vs "hmd" in doc.

Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Cleanup renaming of TextureSwapChain variables/parame…
…ters

Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Add missing ErrorType forward declaration.
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Move Context::error() into Context.cpp
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Rename HmdEnum(.h|.cpp) to Enums(.h|.cpp)
For consistency also rename EnumTest to EnumsTest.

Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Remove obsolete HmdTrackingCapability
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Refer to wrapped types rather than Oculus SDK types.
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Add setter and getter for world scale.
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Remove obsolete TimewarpProjectionDescription.
LayerEyeFovDepth, which this type was used with, has been removed from the
SDK aswell as OvrIntegration, so this type is no longer useful.

Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Rename more string/doc references from Hmd to Session
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Remove mysterious doc
This is probably a remnant of a past Oculus SDK version.

Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Hide HmdStatusFlag and HmdStatusFlags from API.
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Use StaticArrayView rather than raw pointers.
Preserves size information of the return value.

Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Cleanup some documentation.
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Avoid std::string in Error struct
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Refer to OvrIntegration types and methods in doc
Signed-off-by: Squareys <Squareys@googlemail.com>
OvrIntegration: Remove a few ErrorType enum values
Adapting to the corresponding error enum values being removed from the
Oculus SDK in version 1.6.0.

Signed-off-by: Squareys <Squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:cleanup-ovr-integration branch from e4ac9be to 424392d Aug 11, 2016

@Squareys

This comment has been minimized.

Contributor

Squareys commented Aug 11, 2016

@mosra Rebased and removed error enum values to know be OculusSDK 1.6.0 compliant!

I would be really happy, if this could get merged in the next 7 days, if that is possible somehow :)

PS: Hooooly.... AppVeyor was quick this time :O

OvrIntegration: Allow building static library.
Signed-off-by: Squareys <Squareys@googlemail.com>

@mosra mosra merged commit 4379ec9 into mosra:master Aug 15, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
/** The HMD was created as a debug HMD (without real hardware) */
Debug = ovrHmdCap_DebugDevice /* 0x0010 */
};

This comment has been minimized.

@mosra

mosra Aug 15, 2016

Owner

👍 for the idea of having the enum definition only in the *.cpp file. A new thing for me! :)

@mosra

This comment has been minimized.

Owner

mosra commented Aug 15, 2016

Merged. Thanks a lot!

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment