New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static libraries being treated as dynamic libs #16

Merged
merged 2 commits into from Jul 28, 2016

Conversation

Projects
2 participants
@Squareys
Contributor

Squareys commented Jul 28, 2016

Hi @mosra !

I applied the patch you sent me, and copied the changed to OvrIntegration. Works like a charm 馃槈

Greetings, Squareys.

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/configure.h.cmake
${CMAKE_CURRENT_BINARY_DIR}/configure.h)

This comment has been minimized.

@mosra

mosra Jul 28, 2016

Owner

Superfluous newline ;)

This comment has been minimized.

@Squareys

Squareys Jul 28, 2016

Contributor

Now, done. Messed up my git commands :)

@Squareys Squareys force-pushed the Squareys:fix-static-libraries branch from f927fe2 to 56abaa6 Jul 28, 2016

@Squareys Squareys force-pushed the Squareys:fix-static-libraries branch from 56abaa6 to 3a83909 Jul 28, 2016

@mosra mosra merged commit 3a83909 into mosra:master Jul 28, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@mosra

This comment has been minimized.

Owner

mosra commented Jul 28, 2016

馃憤

@Squareys

This comment has been minimized.

Contributor

Squareys commented Jul 28, 2016

Thanks! :D

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment