OvrIntegration: Adapt to API changes in Oculus SDK 1.17.0 #26
Conversation
|
Thank you! One problem I see immediately (maybe you remember): there was no easy way to get the latest SDK from Oculus website, so the CI is stuck on something very outdated. Any idea how to solve this (besides hosting it privately)? |
Squareys
force-pushed
the
ovr-sdk-1.17.0
branch
4 times, most recently
from
bf62b4f
to
4c0c696
Compare
|
@mosra Yup, see last commit. I wonder if the access token expires sometime... otherwise we can refresh it and hope for the cache staying valid? :P |
Squareys
force-pushed
the
ovr-sdk-1.17.0
branch
3 times, most recently
from
b5e49b2
to
ca0e781
Compare
|
Well, alright, it seems to download something else it seems... |
Squareys
force-pushed
the
ovr-sdk-1.17.0
branch
2 times, most recently
from
79e94ef
to
6f9419b
Compare
|
Huh, this is still a thing? :D |
|
@mosra Yes, we didn't merge it, because we didn't manage to get the ovr sdk downloaded by the CI. |
|
Actually, now that I think of it, we wanted to try whether the download key expires somehow. Also, it looks like I need to add some lines to make it build the Debug libraries of the SDK. |
|
Thanks. So, do I understand correctly that without these patches the integration doesn't work with latest SDK? Since I have the magnum.graphics cloud thingy now, I could maybe host the SDK there and circumvent this problem, but I don't know how many license agreements that would break. |
Squareys
force-pushed
the
ovr-sdk-1.17.0
branch
2 times, most recently
from
123dfd2
to
869ca71
Compare
|
Summarizing offline discussions: Solution to Oculus SDK not being automatically downloadable anymore is to host some minimal archive required for the build and use that. To generate it, I added a python script with 869ca71. This will be merged once mosra finds the time after some important bigger changes in the main repository. |
|
Random idea since I don't have time to set up |
Signed-off-by: Squareys <squareys@googlemail.com>
And yes, the oculus website shows some "facebook: Update your browser" html page when using the appveyor download util, but having a user agent "myUserAgentString" works fine! Signed-off-by: Squareys <squareys@googlemail.com>
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
- Coverage 49.41% 49.4% -0.01%
=========================================
Files 12 12
Lines 425 423 -2
=========================================
- Hits 210 209 -1
+ Misses 215 214 -1
Continue to review full report at Codecov.
|
Signed-off-by: Squareys <squareys@googlemail.com>
…ure() Allows changing the mirroring mode. Signed-off-by: Squareys <squareys@googlemail.com>
`-1 == ControllerType::Active`, hence not actually invalid. Signed-off-by: Squareys <squareys@googlemail.com>
You probably shouldn't have said that, because it took me almost 12 months to merge :D Merged in 4e45cd1...11b5740, thanks a lot for continuing with the maintenance here. And for the very helpful Python script. |
Better late than never 😆 Since nobody complained yet... :D Thank you for merging! 🎉 |
Hi @mosra !
Just came across this, this is not urgent, merge whenever you find the time.
Cheers, Jonathan