New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OvrIntegration: Adapt to API changes in Oculus SDK 1.17.0 #26

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
4 participants
@Squareys
Contributor

Squareys commented Sep 14, 2017

Hi @mosra !

Just came across this, this is not urgent, merge whenever you find the time.

Cheers, Jonathan

@mosra

This comment has been minimized.

Owner

mosra commented Sep 14, 2017

Thank you!

One problem I see immediately (maybe you remember): there was no easy way to get the latest SDK from Oculus website, so the CI is stuck on something very outdated. Any idea how to solve this (besides hosting it privately)?

@coveralls

This comment has been minimized.

coveralls commented Sep 14, 2017

Coverage Status

Coverage remained the same at 50.0% when pulling 10d684b on Squareys:ovr-sdk-1.17.0 into 3e4b285 on mosra:master.

@Squareys Squareys force-pushed the Squareys:ovr-sdk-1.17.0 branch 4 times, most recently from bf62b4f to 4c0c696 Sep 15, 2017

@Squareys

This comment has been minimized.

Contributor

Squareys commented Sep 15, 2017

@mosra Yup, see last commit. I wonder if the access token expires sometime... otherwise we can refresh it and hope for the cache staying valid? :P

@Squareys Squareys force-pushed the Squareys:ovr-sdk-1.17.0 branch 3 times, most recently from b5e49b2 to ca0e781 Sep 15, 2017

@Squareys

This comment has been minimized.

Contributor

Squareys commented Sep 15, 2017

Well, alright, it seems to download something else it seems...

@Squareys Squareys force-pushed the Squareys:ovr-sdk-1.17.0 branch 2 times, most recently from 79e94ef to 6f9419b Sep 15, 2017

@coveralls

This comment has been minimized.

coveralls commented Sep 16, 2017

Coverage Status

Coverage remained the same at 50.0% when pulling 6f9419b on Squareys:ovr-sdk-1.17.0 into 3e4b285 on mosra:master.

@mosra mosra added this to In Progress in VR Jan 23, 2018

@mosra

This comment has been minimized.

Owner

mosra commented Jan 23, 2018

Huh, this is still a thing? :D

@Squareys

This comment has been minimized.

Contributor

Squareys commented Jan 24, 2018

@mosra Yes, we didn't merge it, because we didn't manage to get the ovr sdk downloaded by the CI.

@Squareys

This comment has been minimized.

Contributor

Squareys commented Jan 24, 2018

Actually, now that I think of it, we wanted to try whether the download key expires somehow. Also, it looks like I need to add some lines to make it build the Debug libraries of the SDK.

@mosra

This comment has been minimized.

Owner

mosra commented Jan 25, 2018

Thanks. So, do I understand correctly that without these patches the integration doesn't work with latest SDK?

Since I have the magnum.graphics cloud thingy now, I could maybe host the SDK there and circumvent this problem, but I don't know how many license agreements that would break.

@Squareys Squareys force-pushed the Squareys:ovr-sdk-1.17.0 branch 2 times, most recently from 123dfd2 to 869ca71 Apr 16, 2018

@Squareys

This comment has been minimized.

Contributor

Squareys commented Apr 16, 2018

Summarizing offline discussions:

Solution to Oculus SDK not being automatically downloadable anymore is to host some minimal archive required for the build and use that. To generate it, I added a python script with 869ca71.
This is useful anyway, since LibOVR links static CRT by default and therefore is not compatible with all other magnum libraries (which link dynamic CRT by default) and we therefore need to patch the VS projects.

This will be merged once mosra finds the time after some important bigger changes in the main repository.

@mosra

This comment has been minimized.

Owner

mosra commented Apr 25, 2018

Random idea since I don't have time to set up ci.magnum.graphics yet (and won't have for the next x weeks): does the SDK provide some version define that could be used to make it temporarily work both with the currently still downloadable SDK and the latest one? Yes, it's ugly and all, but better than have this totally non-compilable with latest SDK -- I may have a need for a working version soon.

@mosra mosra referenced this pull request Apr 28, 2018

Merged

Simplify Oculus Example #39

Squareys added some commits Sep 14, 2017

OvrIntegration: Adapt to API changes in Oculus SDK 1.17.0
Signed-off-by: Squareys <squareys@googlemail.com>
ci: Use Oculus SDK 1.17.0 on AppVeyor
And yes, the oculus website shows some "facebook: Update your browser"
html page when using the appveyor download util, but having a user agent
"myUserAgentString" works fine!

Signed-off-by: Squareys <squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:ovr-sdk-1.17.0 branch from 869ca71 to d2bc216 May 10, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 10, 2018

Codecov Report

Merging #26 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #26      +/-   ##
=========================================
- Coverage   49.41%   49.4%   -0.01%     
=========================================
  Files          12      12              
  Lines         425     423       -2     
=========================================
- Hits          210     209       -1     
+ Misses        215     214       -1
Impacted Files Coverage Δ
src/Magnum/BulletIntegration/MotionState.cpp 100% <0%> (ø) ⬆️
src/Magnum/BulletIntegration/DebugDraw.cpp 10.25% <0%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a285f...d77584d. Read the comment docs.

Squareys added some commits Apr 16, 2018

Add script to generate minimal ovr_sdk archive
Signed-off-by: Squareys <squareys@googlemail.com>
Ovr: Add MirrorOption enum and parameter to Session::createMirrorText…
…ure()

Allows changing the mirroring mode.

Signed-off-by: Squareys <squareys@googlemail.com>
Ovr: Fix ControllerType enum test
`-1 == ControllerType::Active`, hence not actually invalid.

Signed-off-by: Squareys <squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:ovr-sdk-1.17.0 branch from fac45e7 to d77584d May 11, 2018

@mosra mosra referenced this pull request Jul 25, 2018

Closed

2018.10 release #265

56 of 56 tasks complete

@mosra mosra added this to the 2018.0c milestone Jul 25, 2018

@mosra

This comment has been minimized.

Owner

mosra commented Aug 24, 2018

this is not urgent, merge whenever you find the time.

You probably shouldn't have said that, because it took me almost 12 months to merge :D

Merged in 4e45cd1...11b5740, thanks a lot for continuing with the maintenance here. And for the very helpful Python script.

@mosra mosra closed this Aug 24, 2018

VR automation moved this from In Progress to Done Aug 24, 2018

@Squareys

This comment has been minimized.

Contributor

Squareys commented Aug 24, 2018

it took me almost 12 months to merge

Better late than never 😆 Since nobody complained yet... :D

Thank you for merging! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment