OvrIntegration: Adapt to API changes in Oculus SDK 1.17.0

[Squareys]

Hi @mosra !

Just came across this, this is not urgent, merge whenever you find the time.

Cheers, Jonathan

[mosra]

Thank you!

One problem I see immediately (maybe you remember): there was no easy way to get the latest SDK from Oculus website, so the CI is stuck on something very outdated. Any idea how to solve this (besides hosting it privately)?

[coveralls]

Coverage remained the same at 50.0% when pulling 10d684b on Squareys:ovr-sdk-1.17.0 into 3e4b285 on mosra:master.

[Squareys]

@mosra Yup, see last commit. I wonder if the access token expires sometime... otherwise we can refresh it and hope for the cache staying valid? :P

[Squareys]

Well, alright, it seems to download something else it seems...

[coveralls]

Coverage remained the same at 50.0% when pulling 6f9419b on Squareys:ovr-sdk-1.17.0 into 3e4b285 on mosra:master.

[mosra]

Huh, this is still a thing? :D

[Squareys]

@mosra Yes, we didn't merge it, because we didn't manage to get the ovr sdk downloaded by the CI.

[Squareys]

Actually, now that I think of it, we wanted to try whether the download key expires somehow. Also, it looks like I need to add some lines to make it build the Debug libraries of the SDK.

[mosra]

Thanks. So, do I understand correctly that without these patches the integration doesn't work with latest SDK?

Since I have the magnum.graphics cloud thingy now, I could maybe host the SDK there and circumvent this problem, but I don't know how many license agreements that would break.

[Squareys]

Summarizing offline discussions:

Solution to Oculus SDK not being automatically downloadable anymore is to host some minimal archive required for the build and use that. To generate it, I added a python script with 869ca71.
This is useful anyway, since LibOVR links static CRT by default and therefore is not compatible with all other magnum libraries (which link dynamic CRT by default) and we therefore need to patch the VS projects.

This will be merged once mosra finds the time after some important bigger changes in the main repository.

[mosra]

Random idea since I don't have time to set up ci.magnum.graphics yet (and won't have for the next x weeks): does the SDK provide some version define that could be used to make it temporarily work both with the currently still downloadable SDK and the latest one? Yes, it's ugly and all, but better than have this totally non-compilable with latest SDK -- I may have a need for a working version soon.

[codecov-io]

Codecov Report

Merging #26 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #26      +/-   ##
=========================================
- Coverage   49.41%   49.4%   -0.01%     
=========================================
  Files          12      12              
  Lines         425     423       -2     
=========================================
- Hits          210     209       -1     
+ Misses        215     214       -1

Impacted Files	Coverage Δ
src/Magnum/BulletIntegration/MotionState.cpp	100% <0%> (ø)	⬆️
src/Magnum/BulletIntegration/DebugDraw.cpp	10.25% <0%> (+0.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a285f...d77584d. Read the comment docs.

[mosra]

this is not urgent, merge whenever you find the time.

You probably shouldn't have said that, because it took me almost 12 months to merge :D

Merged in 4e45cd1...11b5740, thanks a lot for continuing with the maintenance here. And for the very helpful Python script.

[Squareys]

it took me almost 12 months to merge

Better late than never 😆 Since nobody complained yet... :D

Thank you for merging! 🎉