Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Dart integration v2 #29
This PR improves the DartIntegration introduced in #28 .. It is still work in progress, but at a quite good state:
For an example usage, you can have a look at this branch, which I am updating to match the updates on this integration.
Let me know what you think!
Hi, wow, didn't expect this so soon! :)
Did just a quick glance over the new stuff and made some minor course correction comments, hope that's okay :) Will dig deeper and discuss the overall design with you later -- I understand lots of this is still in a WIP stage.
@@ Coverage Diff @@ ## master #29 +/- ## ========================================= - Coverage 55.33% 46.53% -8.8% ========================================= Files 12 12 Lines 253 462 +209 ========================================= + Hits 140 215 +75 - Misses 113 247 +134
Sorry for the delays with this.
I made just a general comment regarding the design, with the goal to make this whole thing more testable -- currently Travis can't run the code at all due to requirement of the GL context, which is quite bad for numerous reasons, code coverage being one of them. After I can see what's being covered by tests and what not, I can comment further.
I'm not saying this often enough, sorry: thank you for the continued effort with this :)
referenced this pull request
Feb 19, 2018
I did a thorough review now. I like how simple it turned out in the end and how testable it is now :)
Last round, hopefully :)
There's still the constructor/destructor stuff and some leftover
shared_ptrs that i pointed out in the previous review, though ;)
Feb 24, 2018
Feb 26, 2018
Merged, thanks a lot. Code coverage including GL tests says 92%, you're doing amazing work
I made a few small changes to the public API that might break your code, see e3efe6d, 3c3d554 and 7676fdb. In 016c252 I removed a public function that I think was superfluous and never used in any code, I hope that's okay.
Looking forward to the example now :)