/ magnum-integration Public
BulletIntegration: fix Matrix3x3 conversion along with unit tests #34
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Bullet matrices are row-major, Magnum matrices are column-major.
Matrix3x3unit test did not account for this and tested the wrong behavior.
The test for
Matrix4x4seems fine, haven't looked in detail, though.
This probably hasn't been noticed before because
Matrix3x3conversion only in the Magnum -> Bullet direction, and this is typically only done once during
btRigidBodyinitialization. The bullet example in magnum-examples uses identity rotation at initialization...