ImGuiIntegration: add imageButton()#38
Closed
williamjcm wants to merge 4 commits intomosra:masterfrom
williamjcm:imgui-imagebutton
Closed
ImGuiIntegration: add imageButton()#38williamjcm wants to merge 4 commits intomosra:masterfrom williamjcm:imgui-imagebutton
williamjcm wants to merge 4 commits intomosra:masterfrom
williamjcm:imgui-imagebutton
Conversation
This should prevent issues with Dear ImGui version 1.68 WIP and later.
mosra
reviewed
Feb 17, 2019
Owner
mosra
left a comment
mosra
left a comment
There was a problem hiding this comment.
Thanks a lot! Just minor things.
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
======================================
Coverage 45.3% 45.3%
======================================
Files 13 13
Lines 415 415
======================================
Hits 188 188
Misses 227 227Continue to review full report at Codecov.
|
And also fix imageButton()'s default background color.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds the corresponding test in ImGuiWidgetsGLTest.
Since I tested with ImGui 1.68 WIP, which apparently needs some time to display stuff, I had to edit both ImGuiWidgetsGLTest and ImGuiContextGLTest to add some delay between the dummy first frame and the actual test frames.
Review and feedback are welcome!