Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGuiIntegration: add imageButton() #38

Closed
wants to merge 4 commits into from
Closed

ImGuiIntegration: add imageButton() #38

wants to merge 4 commits into from

Conversation

williamjcm
Copy link
Contributor

Also adds the corresponding test in ImGuiWidgetsGLTest.

Since I tested with ImGui 1.68 WIP, which apparently needs some time to display stuff, I had to edit both ImGuiWidgetsGLTest and ImGuiContextGLTest to add some delay between the dummy first frame and the actual test frames.

Review and feedback are welcome!

This should prevent issues with Dear ImGui version 1.68 WIP and later.
Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Just minor things.

src/Magnum/ImGuiIntegration/Widgets.h Outdated Show resolved Hide resolved
src/Magnum/ImGuiIntegration/Widgets.h Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #38   +/-   ##
======================================
  Coverage    45.3%   45.3%           
======================================
  Files          13      13           
  Lines         415     415           
======================================
  Hits          188     188           
  Misses        227     227

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384bd61...2deebd5. Read the comment docs.

And also fix imageButton()'s default background color.
@mosra mosra added this to the 2019.0b milestone Feb 17, 2019
@mosra mosra added this to TODO in GUI via automation Feb 17, 2019
@mosra
Copy link
Owner

mosra commented Feb 17, 2019

Merged as db791be, c715e73 and 62918a2. Thanks a lot! 👍

@mosra mosra closed this Feb 17, 2019
GUI automation moved this from TODO to Done Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
GUI
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants