Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen integration #40

Merged
merged 3 commits into from Mar 13, 2019

Conversation

Projects
2 participants
@mosra
Copy link
Owner

mosra commented Feb 22, 2019

Done from both the coding and documentation side, except that it's failing to build on MSVC and Travis does not want to trigger the builds for latest commits.

TODO:

  • Convince Travis to build this, fix the remaining issues
  • Fix MSVC build
  • Clean up the dirty commits
  • Apply the following to Magnum post-merge:
diff --git a/doc/types.dox b/doc/types.dox
index d59abd9d9..677a2fd2a 100644
--- a/doc/types.dox
+++ b/doc/types.dox
@@ -216,6 +216,9 @@ documentation of each `Integration.h` header for details:
 
 -   Math-related Vulkan structures --- @ref Magnum/Vk/Integration.h, part of
     the @ref Vk library
+-   All Eigen types --- @ref Magnum/EigenIntegration/Integration.h and
+    @ref Magnum/EigenIntegration/GeometryIntegration.h, part of the
+    @ref EigenIntegration library
 -   All GLM types --- @ref Magnum/GlmIntegration/Integration.h,
     @ref Magnum/GlmIntegration/GtcIntegration.h and
     @ref Magnum/GlmIntegration/GtxIntegration.h, part of the

@mosra mosra added this to the 2019.0b milestone Feb 22, 2019

@mosra mosra self-assigned this Feb 22, 2019

@mosra mosra added this to TODO in Math via automation Feb 22, 2019

@mosra mosra referenced this pull request Feb 22, 2019

Closed

Cannot load plugins #320

@mosra mosra force-pushed the eigen branch from fa80ac8 to 165cc22 Feb 22, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #40 into master will increase coverage by 2.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage      71%   73.73%   +2.73%     
==========================================
  Files          20       22       +2     
  Lines         769      849      +80     
==========================================
+ Hits          546      626      +80     
  Misses        223      223
Impacted Files Coverage Δ
src/Magnum/EigenIntegration/GeometryIntegration.h 100% <100%> (ø)
src/Magnum/EigenIntegration/Integration.h 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5491e...ea86731. Read the comment docs.

@mosra mosra force-pushed the eigen branch 4 times, most recently from e6db40e to 2d4d898 Mar 12, 2019

mosra added some commits Feb 7, 2019

package: enable Eigen in all packages and CIs.
Not so easy, apparently. Uargh how clueless can people be.
EigenIntegration: make this thing build on MSVC.
Somehow it needs the default template parameters explicitly. Took me one
month of procrastinating a reboot to Windows, two hours of waiting for
Visual Studio update to get downloaded and five minutes of random
guessing.

@mosra mosra force-pushed the eigen branch from 2d4d898 to ea86731 Mar 13, 2019

@mosra mosra marked this pull request as ready for review Mar 13, 2019

@mosra

This comment has been minimized.

Copy link
Owner Author

mosra commented Mar 13, 2019

MSVC build fixed in 9f25684, fortunately it was enough to just specify the default template parameters explicitly. The rest was minor errors in Travis CI config, all green now.

@mosra mosra merged commit ea86731 into master Mar 13, 2019

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Math automation moved this from TODO to Done Mar 13, 2019

@mosra mosra deleted the eigen branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.