Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen integration #40

merged 3 commits into from Mar 13, 2019

Eigen integration #40

merged 3 commits into from Mar 13, 2019


Copy link

@mosra mosra commented Feb 22, 2019

Done from both the coding and documentation side, except that it's failing to build on MSVC and Travis does not want to trigger the builds for latest commits.


  • Convince Travis to build this, fix the remaining issues
  • Fix MSVC build
  • Clean up the dirty commits
  • Apply the following to Magnum post-merge:
diff --git a/doc/types.dox b/doc/types.dox
index d59abd9d9..677a2fd2a 100644
--- a/doc/types.dox
+++ b/doc/types.dox
@@ -216,6 +216,9 @@ documentation of each `Integration.h` header for details:
 -   Math-related Vulkan structures --- @ref Magnum/Vk/Integration.h, part of
     the @ref Vk library
+-   All Eigen types --- @ref Magnum/EigenIntegration/Integration.h and
+    @ref Magnum/EigenIntegration/GeometryIntegration.h, part of the
+    @ref EigenIntegration library
 -   All GLM types --- @ref Magnum/GlmIntegration/Integration.h,
     @ref Magnum/GlmIntegration/GtcIntegration.h and
     @ref Magnum/GlmIntegration/GtxIntegration.h, part of the

@mosra mosra added this to the 2019.0b milestone Feb 22, 2019
@mosra mosra self-assigned this Feb 22, 2019
@mosra mosra added this to TODO in Math via automation Feb 22, 2019
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #40 into master will increase coverage by 2.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
+ Coverage      71%   73.73%   +2.73%     
  Files          20       22       +2     
  Lines         769      849      +80     
+ Hits          546      626      +80     
  Misses        223      223
Impacted Files Coverage Δ
src/Magnum/EigenIntegration/GeometryIntegration.h 100% <100%> (ø)
src/Magnum/EigenIntegration/Integration.h 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5491e...ea86731. Read the comment docs.

@mosra mosra force-pushed the eigen branch 4 times, most recently from e6db40e to 2d4d898 Compare March 13, 2019 10:39
Somehow it needs the default template parameters explicitly. Took me one
month of procrastinating a reboot to Windows, two hours of waiting for
Visual Studio update to get downloaded and five minutes of random
Not so easy, apparently. Uargh how clueless can people be.
@mosra mosra marked this pull request as ready for review March 13, 2019 10:41
Copy link
Owner Author

mosra commented Mar 13, 2019

MSVC build fixed in 9f25684, fortunately it was enough to just specify the default template parameters explicitly. The rest was minor errors in Travis CI config, all green now.

@mosra mosra merged commit ea86731 into master Mar 13, 2019
Math automation moved this from TODO to Done Mar 13, 2019
@mosra mosra deleted the eigen branch March 13, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

2 participants