Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGuiIntegration: add handling of the Space key. #44

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
2 participants
@williamjcm
Copy link
Contributor

williamjcm commented Mar 11, 2019

This provides full support for ImGui keyboard navigation.

Those changes were tested in a project's copy of magnum-integration.

ImGuiIntegration: add handling of the Space key.
This provides full support for ImGui keyboard navigation.

@mosra mosra added this to the 2019.0b milestone Mar 11, 2019

@mosra mosra added this to TODO in GUI via automation Mar 11, 2019

@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Mar 11, 2019

Thank you!

Random question: are there other missing keys or this was the last one missing?

@williamjcm

This comment has been minimized.

Copy link
Contributor Author

williamjcm commented Mar 11, 2019

This was apparently the only one missing, since I didn't get any other assertion failures for missing keys in the keymap.

@mosra mosra merged commit a1cc1e1 into mosra:master Mar 11, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

GUI automation moved this from TODO to Done Mar 11, 2019

@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Mar 11, 2019

Awesome, merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.