Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartIntegration-v3 #47

wants to merge 6 commits into from

DartIntegration-v3 #47

wants to merge 6 commits into from


Copy link

@costashatz costashatz commented Jul 7, 2019

DartIntegration: This pull request fixes a small bug in the cylinder shape and adds support for the cone shape..

Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #47 into master will increase coverage by 0.43%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
+ Coverage   74.73%   75.17%   +0.43%     
  Files          21       21              
  Lines         847      862      +15     
+ Hits          633      648      +15     
  Misses        214      214
Impacted Files Coverage Δ
src/Magnum/DartIntegration/ConvertShapeNode.h 100% <ø> (ø) ⬆️
src/Magnum/DartIntegration/World.cpp 0% <0%> (ø) ⬆️
src/Magnum/DartIntegration/ConvertShapeNode.cpp 96.13% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40011af...ebd4fb0. Read the comment docs.

Copy link

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Two little things.

src/Magnum/DartIntegration/ConvertShapeNode.cpp Outdated Show resolved Hide resolved
src/Magnum/DartIntegration/Test/ConvertShapeNodeTest.cpp Outdated Show resolved Hide resolved
@mosra mosra added this to the 2019.0b milestone Jul 8, 2019
@mosra mosra added this to TODO in Physics via automation Jul 8, 2019
Copy link

mosra commented Jul 15, 2019

Merged in e78af90, 398feb7, 50e7ec2, 33f45c7, 7964c6d and dc029da. Thanks a lot for the continued maintenance!

@mosra mosra closed this Jul 15, 2019
Physics automation moved this from TODO to Done Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

3 participants