New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibOvrIntegration: API and codestyle fixes. #5

Merged
merged 5 commits into from Jun 25, 2015

Conversation

Projects
2 participants
@Squareys
Contributor

Squareys commented Jun 23, 2015

Hi @mosra,

this pullrequest fixes the issues/requests mentioned in #4 !

Greetings,
Squareys

Squareys added some commits Jun 23, 2015

LibOvrIntegration: Fix problem with windef includes.
The aforementioned header defines symbols `far` and `near` which conflicts
with the parameter naming for `Hmd::projectionMatrix()`.

Signed-off-by: Squareys <Squareys@googlemail.com>
LibOvrIntegration: Rename getters.
Change `getFoo()` to simply `foo()` to stay consistent with the rest of
magnums code.

Signed-off-by: Squareys <Squareys@googlemail.com>
LibOvrIntegration: Rename LibOvrContext to Context.
Again, for consistency with other magnum code.

Signed-off-by: Squareys <Squareys@googlemail.com>
LibOvrIntegration: Return std::array from Hmd::eyePoses().
Avoids unnecessary heap allocation.

Signed-off-by: Squareys <Squareys@googlemail.com>
LibOvrIntegration: Fix method order of Context.
Rule for method order is:
 - static methods
 - constructor(s), then copy, then move constructor(s)
 - destructor
 - operators
 - everything else

Signed-off-by: Squareys <Squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:libovr-api-fixes branch from f01785f to 874b8f6 Jun 23, 2015

Squareys added a commit to Squareys/magnum-examples that referenced this pull request Jun 23, 2015

ovr: Adapt to LibOvrIntegration API changes.
See the (pullrequest on magnum-integration)[mosra/magnum-integration#5].

Signed-off-by: Squareys <Squareys@googlemail.com>

Squareys added a commit to Squareys/magnum-examples that referenced this pull request Jun 23, 2015

ovr: Adapt to LibOvrIntegration API changes.
See the pullrequest mosra/magnum-integration#5 for more information.

Signed-off-by: Squareys <Squareys@googlemail.com>

@mosra mosra merged commit 874b8f6 into mosra:master Jun 25, 2015

@mosra

This comment has been minimized.

Owner

mosra commented Jun 25, 2015

Finally merged. Thanks!

@Squareys

This comment has been minimized.

Contributor

Squareys commented Jun 25, 2015

Thank you, too!

@Squareys Squareys deleted the Squareys:libovr-api-fixes branch Jul 28, 2015

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment