ImGuiIntegration: implement updating application cursor #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melix99
reviewed
Oct 19, 2019
GlfwApplication supports only a subset of SDL2 cursors, so there has to be some ugly SFINAE to make the things work.
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 74.77% 60.08% -14.7%
==========================================
Files 21 14 -7
Lines 880 486 -394
==========================================
- Hits 658 292 -366
+ Misses 222 194 -28
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on mosra/magnum#383. Putting into a PR because I'm not sure if I can wrap up the other one in time for a release.
Cc: @Melix19