Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGuiIntegration: implement updating application cursor #56

Merged
merged 1 commit into from Nov 6, 2019
Merged

Conversation

@mosra
Copy link
Owner

mosra commented Oct 19, 2019

Depends on mosra/magnum#383. Putting into a PR because I'm not sure if I can wrap up the other one in time for a release.

Cc: @Melix19

@mosra mosra added this to the 2019.0c milestone Oct 19, 2019
@mosra mosra added this to TODO in GUI via automation Oct 19, 2019
GlfwApplication supports only a subset of SDL2 cursors, so there has to
be some ugly SFINAE to make the things work.
@mosra mosra force-pushed the imgui-cursor branch from 1646a1c to dd5f030 Nov 6, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #56 into master will decrease coverage by 14.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   74.77%   60.08%   -14.7%     
==========================================
  Files          21       14       -7     
  Lines         880      486     -394     
==========================================
- Hits          658      292     -366     
+ Misses        222      194      -28
Impacted Files Coverage Δ
src/Magnum/ImGuiIntegration/Context.h 100% <ø> (ø) ⬆️
src/Magnum/ImGuiIntegration/Context.cpp 3.12% <0%> (-79.92%) ⬇️
src/Magnum/BulletIntegration/DebugDraw.cpp 12.82% <0%> (-3.46%) ⬇️
src/Magnum/BulletIntegration/MotionState.cpp 84.21% <0%> (-1.51%) ⬇️
src/Magnum/ImGuiIntegration/Integration.h 100% <0%> (ø) ⬆️
src/Magnum/ImGuiIntegration/Widgets.h
src/Magnum/DartIntegration/ConvertShapeNode.cpp
src/Magnum/DartIntegration/Object.h
src/Magnum/DartIntegration/World.cpp
src/Magnum/DartIntegration/Object.cpp
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88bd1a2...dd5f030. Read the comment docs.

@mosra mosra merged commit dd5f030 into master Nov 6, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/branch AppVeyor build cancelled
Details
continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
GUI automation moved this from TODO to Done Nov 6, 2019
@mosra mosra deleted the imgui-cursor branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
GUI
  
Done
3 participants
You can’t perform that action at this time.