DartIntegration: use EigenIntegration and small check for NaN values - #58
costashatz wants to merge 5 commits into
Conversation
| /* Pass it to Magnum */ | ||
| _transformation.resetTransformation() | ||
| .rotate(theta, u) | ||
| .rotate(angle, axis) |
There was a problem hiding this comment.
Why go through the pain of creating a quaternion and then again converting that to a transformation matrix inside rotate()? Wouldn't just the following work as well?
_transformation.setTransformation(trans);There was a problem hiding this comment.
error: ‘class Magnum::SceneGraph::AbstractBasicTranslationRotation3D<float>’ has no member named ‘setTransformation’; did you mean ‘resetTransformation’?
There was a problem hiding this comment.
blargh, forgot about this 😅 ... okay then, keep it as-is
There was a problem hiding this comment.
I guess you should provide this function? What is the rationale of not providing it for AbstractFeature?
There was a problem hiding this comment.
Because some transformations support only translation, or only translation/rotation, and the full transformation matrix could be too general for these.
... but I should provide rotate() taking a quat, definitely, adding that to my TODOs.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 74.77% 74.44% -0.33%
==========================================
Files 21 21
Lines 880 900 +20
==========================================
+ Hits 658 670 +12
- Misses 222 230 +8
Continue to review full report at Codecov.
|
mosra
left a comment
mosra
left a comment
There was a problem hiding this comment.
Happy! Let's wait until the CIs finish, then I merge.
3 participants
This PR adds the following to the DartIntegration: