New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DartIntegration: use EigenIntegration and small check for NaN values #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
||
/* Pass it to Magnum */ | ||
_transformation.resetTransformation() | ||
.rotate(theta, u) | ||
.rotate(angle, axis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why go through the pain of creating a quaternion and then again converting that to a transformation matrix inside rotate()
? Wouldn't just the following work as well?
_transformation.setTransformation(trans);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error: ‘class Magnum::SceneGraph::AbstractBasicTranslationRotation3D<float>’ has no member named ‘setTransformation’; did you mean ‘resetTransformation’?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blargh, forgot about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you should provide this function? What is the rationale of not providing it for AbstractFeature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because some transformations support only translation, or only translation/rotation, and the full transformation matrix could be too general for these.
... but I should provide rotate()
taking a quat, definitely, adding that to my TODOs.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 74.77% 74.44% -0.33%
==========================================
Files 21 21
Lines 880 900 +20
==========================================
+ Hits 658 670 +12
- Misses 222 230 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy! Let's wait until the CIs finish, then I merge.
This PR adds the following to the DartIntegration: