New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImGuiIntegration: make ImFontAtlas texture accessible #61
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 74.55% 73.97% -0.58%
==========================================
Files 21 21
Lines 900 903 +3
==========================================
- Hits 671 668 -3
- Misses 229 235 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you (and extra thanks for writing the docs as well
One more thing -- could you do simplify the ternary condition we talked about? You mentioned it worked well in your last comment in #60. (To be extra sure, if you could test that also an ImGuiIntegration::image()
widget still work as expected after that change, that'd be great.)
* | ||
* @return Reference to the @cpp GL::Texture2D @ce in @cpp ImFontAtlas @ce | ||
*/ | ||
GL::Texture2D& getAtlasTexture(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be just atlasTexture()
? Magnum doesn't use get
prefixes anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, my bad
Merged as b3c65b9, thank you! :) |
btw i have been testing with the ternary statement simplified, and everything works |
There is a tiny bug in here: When the Context is moved, the pointer to I will follow up with a tiny PR. |
Fixes #60