Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGuiIntegration: Fix assertion when move assigning empty context #63

merged 1 commit into from Jan 5, 2020


Copy link

@Squareys Squareys commented Jan 5, 2020

@mosra As discussed via gitter, here's the follow-up fix for #62 .


@mosra mosra added this to the 2020.0a milestone Jan 5, 2020
@mosra mosra added this to TODO in GUI via automation Jan 5, 2020
When _context is nullptr in `this` or `other` the current context is unset
which fails in ImGui::GetIO().

Signed-off-by: Squareys <>
@Squareys Squareys force-pushed the fix-imgui-context-move-assign branch from d0ec813 to e17f7de Compare January 5, 2020 18:35
Copy link

codecov-io commented Jan 5, 2020

Codecov Report

Merging #63 into master will decrease coverage by 18.88%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #63       +/-   ##
- Coverage   74.45%   55.56%   -18.89%     
  Files          21       19        -2     
  Lines         912      844       -68     
- Hits          679      469      -210     
- Misses        233      375      +142
Impacted Files Coverage Δ
src/Magnum/ImGuiIntegration/Context.cpp 2.71% <0%> (-81.44%) ⬇️
src/Magnum/ImGuiIntegration/Context.h 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c9235...e17f7de. Read the comment docs.

@mosra mosra merged commit e17f7de into mosra:master Jan 5, 2020
GUI automation moved this from TODO to Done Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

3 participants