ImGuiIntegration: Fix assertion when move assigning empty context#63
Merged
Merged
Conversation
mosra
reviewed
Jan 5, 2020
When _context is nullptr in `this` or `other` the current context is unset which fails in ImGui::GetIO(). Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
fix-imgui-context-move-assign
branch
from
d0ec813 to
e17f7de
Compare
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
===========================================
- Coverage 74.45% 55.56% -18.89%
===========================================
Files 21 19 -2
Lines 912 844 -68
===========================================
- Hits 679 469 -210
- Misses 233 375 +142
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mosra As discussed via gitter, here's the follow-up fix for #62 .
Best,
Jonathan.