Repository navigation
Add usage hints to vector-math integrations. - #66
Closed
JacksonCampolattaro wants to merge 2 commits into
Closed
JacksonCampolattaro wants to merge 2 commits into
JacksonCampolattaro wants to merge 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
======================================
Coverage 74.5% 74.5%
======================================
Files 21 21
Lines 914 914
======================================
Hits 681 681
Misses 233 233Continue to review full report at Codecov.
|
Owner
|
Thank you! :) Merged as a4e3263, I just converted the code snippets to be checked for compile errors (which uncovered an accidentally reversed order of arguments in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR request adds short explanations of the functionality included in GlmIntegration and EigenIntegration. This should make it more obvious that both allow for casting to and from Magnum's native vector types. It should also make it more clear which headers must be included to take advantage of this functionality.
Short examples of the syntax are adapted from the blog post that explained the integration features when they were first introduced.