Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for draw list user callbacks in ImGui integration #84

Closed
wants to merge 1 commit into from

Conversation

arximboldi
Copy link
Contributor

Fixes #83

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #84 (3b64a76) into master (8e1ee6c) will decrease coverage by 13.37%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #84       +/-   ##
===========================================
- Coverage   89.83%   76.45%   -13.38%     
===========================================
  Files          16       21        +5     
  Lines         590      960      +370     
===========================================
+ Hits          530      734      +204     
- Misses         60      226      +166     
Impacted Files Coverage Δ
src/Magnum/ImGuiIntegration/Context.cpp 85.97% <66.66%> (-4.94%) ⬇️
src/Magnum/EigenIntegration/Integration.h 100.00% <0.00%> (ø)
src/Magnum/DartIntegration/ConvertShapeNode.h 100.00% <0.00%> (ø)
src/Magnum/DartIntegration/Object.cpp 0.00% <0.00%> (ø)
src/Magnum/DartIntegration/Object.h 0.00% <0.00%> (ø)
src/Magnum/DartIntegration/ConvertShapeNode.cpp 96.48% <0.00%> (ø)
src/Magnum/DartIntegration/World.cpp 0.00% <0.00%> (ø)
src/Magnum/BulletIntegration/MotionState.cpp 85.71% <0.00%> (+1.50%) ⬆️
src/Magnum/BulletIntegration/DebugDraw.cpp 15.90% <0.00%> (+2.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e1ee6c...3b64a76. Read the comment docs.

@mosra mosra added this to the 2022.0a milestone Feb 3, 2022
@mosra mosra added this to TODO in GUI via automation Feb 3, 2022
@pezcode
Copy link
Contributor

pezcode commented Jul 27, 2022

Hey @arximboldi 👋 Any chance you could rebase on top of master and fix the code style to match the Corrade coding style?

Namely:

  • if () -> if()
  • opening brackets on same line -> if() {

Ideally there would also be a test in ContextGLTest.cpp that checks that the callback is called correctly.

Let me know if you don't have the time or want me to do this, I don't mind taking over.

@mosra
Copy link
Owner

mosra commented Jul 27, 2022

This again slipped through my attention, sorry. At first I waited until we had the test scaffolding set up, but then just completely forgot to get back to this.

@pezcode if you're able to add the tests, that would be the most great. Coding-style-wise, don't bother, I can fix that during merge ;)

@arximboldi
Copy link
Contributor Author

I don't have time to work on this now so I would appreciate if someone can pick it up. Thank you a lot!

@pezcode
Copy link
Contributor

pezcode commented Jul 28, 2022

I opened #98. I would've preferred to have just one PR, but this way we get CI tests running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
GUI
  
Done
Development

Successfully merging this pull request may close these issues.

ImGui integration does not support adding UserCallback to DrawList
3 participants