Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analyzer warning about variable used before initialization in TinyGltfImporter #104

Closed
jonesmz opened this issue Aug 23, 2021 · 2 comments

Comments

@jonesmz
Copy link

jonesmz commented Aug 23, 2021

/home/jonesmz/osp-magnum/3rdparty/magnum-plugins/src/MagnumPlugins/TinyGltfImporter/TinyGltfImporter.cpp: In member function ‘virtual void Magnum::Trade::TinyGltfImporter::doOpenData(Corrade::Containers::ArrayView<const char>)’:
/home/jonesmz/osp-magnum/3rdparty/magnum-plugins/src/MagnumPlugins/TinyGltfImporter/TinyGltfImporter.cpp:272:27: warning: ‘callbacks.tinygltf::FsCallbacks::WriteWholeFile’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  272 |     tinygltf::FsCallbacks callbacks;
      |                           ^~~~~~~~~
@mosra mosra added this to the 2021.0a milestone Sep 12, 2021
@mosra mosra added this to TODO in Asset management via automation Sep 12, 2021
@mosra
Copy link
Owner

mosra commented Sep 12, 2021

Yep, I started getting this warning after an upgrade to GCC 10 as well. The cause of it was harmless though (it was for a WriteWholeFile callback, which isn't used) nevertheless it's good to have a warning-free build.

Fixed in 310228f, sorry for the extreme delay.

@mosra mosra closed this as completed Sep 12, 2021
Asset management automation moved this from TODO to Done Sep 12, 2021
@jonesmz
Copy link
Author

jonesmz commented Sep 13, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants