GltfImporter: spot light with outer angle of 90° produces error

[pezcode]

KHR_lights_punctual states:

outerConeAngle | Must be greater than innerConeAngle and less than or equal to PI / 2.0

So 90° should be allowed 🙇

Relevant code is here:

magnum-plugins/src/MagnumPlugins/GltfImporter/GltfImporter.cpp

Line 2160 in 8e5cf7a

if(innerConeAngle < Rad(0.0_degf) || innerConeAngle >= outerConeAngle || outerConeAngle >= Rad(90.0_degf)) {

[mosra]

Thanks, yes this is obviously a bug on my side. Though I wonder if changing from > to >= will actually fix it due to the imprecisions happening when converting from degrees to radians, or from 64-bit doubles to floats...

I'll look into this as soon as I can think straight again, got some nasty cold this week.

[pezcode]

the imprecisions

Maybe just warning (and possibly clamping) is a safer solution.

Anyway, there's no rush. Get well soon🙏

[mosra]

Fixed in c39f2c5. I expected some nasty floating-point issues but it seems to "just work" also with a double-precision representation of 90°, so yay.

[pezcode]

Thank you 😊