Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miss reference over libjpeg include folder name. #51

Closed
hunt978 opened this issue Feb 7, 2019 · 1 comment
Closed

miss reference over libjpeg include folder name. #51

hunt978 opened this issue Feb 7, 2019 · 1 comment
Assignees
@mosra
Labels
changelog mention added
Projects
Asset management
Milestone
2019.10

Comments

@hunt978
Copy link

hunt978 commented Feb 7, 2019

magnum-plugins/src/MagnumPlugins/JpegImageConverter/CMakeLists.txt

Line 51 in 9c81cdc

${JPEG_INCLUDE_DIRS})

may should be the ${JPEG_INCLUDE_DIR} without the S.
@mosra mosra added this to the 2019.0b milestone Feb 7, 2019
@mosra mosra added this to TODO in Asset management via automation Feb 7, 2019
@mosra mosra self-assigned this Feb 7, 2019
@mosra
Copy link
Owner

mosra commented Feb 7, 2019

Oh, you're right, sorry about that. For some reason the CMake FindJPEG module didn't follow the common naming scheme and this wasn't corrected until version 3.12.

Fixed in d0b3385. Thanks a lot for reporting this! 👍

@mosra mosra closed this as completed Feb 7, 2019
Asset management automation moved this from TODO to Done Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mosra mosra

Labels
changelog mention added
Projects
Asset management
  
Done
Milestone
2019.10
Development

No branches or pull requests
2 participants
@mosra @hunt978