Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DrWavAudioImporterTest: cmake error when CORRADE_BUILD_STATIC=ON and BUILD_PLUGINS_STATIC=OFF #78

Closed
rune-scape opened this issue Feb 10, 2020 · 2 comments
Closed

DrWavAudioImporterTest: cmake error when CORRADE_BUILD_STATIC=ON and BUILD_PLUGINS_STATIC=OFF #78

rune-scape opened this issue Feb 10, 2020 · 2 comments
Labels
changelog mention added
Projects
Project management
Milestone
2020.06

Comments

@rune-scape
Copy link
Contributor

magnum-plugins/src/MagnumPlugins/DrWavAudioImporter/Test/CMakeLists.txt

Line 102 in d78e390

set_target_properties(DrWavImporterTest PROPERTIES ENABLE_EXPORTS ON)

DrWavImporterTest should be DrWavAudioImporterTest as far as I can tell.
@rune-scape
Copy link
Contributor Author

Just realized I already wrote the fix for this and i think its in the meshdata branch

@mosra mosra added this to Done in Project management Feb 12, 2020
@mosra mosra added this to the 2020.0a milestone Feb 12, 2020
@mosra
Copy link
Owner

mosra commented Feb 12, 2020

Yep I commited this under your name, but then life stuff got in the way and so the push to master got delayed (e8e7ae2) :)

Thanks for this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog mention added
Projects
Project management
  
Done
Milestone
2020.06
Development

No branches or pull requests
2 participants
@mosra @rune-scape