AssimpImporter: Simplify skinMerge() test #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea why the C wrappers are not there but the underlying C++ implementation is. But it's assimp we're talking about here, any sanity assumption go outta the window. AND OF COURSE things are never simple with this pile of hacks, so we still have to use the C wrappers for versions < 4.0. It also leaks some allocated memory inside that CopyScene, so VERY WONDERFUL, YES.
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
assimp-skinning-merge-skins-test
branch
from
49db760
to
70ab59b
Compare
Codecov Report
@@ Coverage Diff @@
## next #100 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 101 101
Lines 7628 7628
=======================================
Hits 7223 7223
Misses 405 405 Continue to review full report at Codecov.
|
mosra
reviewed
Jul 8, 2021
| Unfortunately, <assimp/SceneCombiner.h> is available only since 4.0, so | ||
| on the ancient 3.2 use the C API (and assume nobody needs the insane corner case of running the test against Assimp 3.2 that has export APIs | ||
| disabled). */ | ||
| #ifdef ASSIMP_HAS_SCENE_COMBINER |
There was a problem hiding this comment.
The #include block related to this should get cleaned up as well. I'll do it during merge.
Otherwise looks great, thanks a lot! 👍
|
I went ahead and rewrote also the Assimp-specific matrix operations and squashed the whole thing into 9bf2b2b. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is against
next!Hi @mosra & @pezcode !
Thank you both for the amazing work on #99, here's a small contribution with the hand-crafted gltf file replacing the leaky scene copy.
Best,
Jonathan