Closed
Conversation
- texture coordinate types were incorrectly documented as Vector3* - tangent types were not mentioned - KHR_materials_pbrSpecularGlossiness link was moved to Archived
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 95.25% 95.15% -0.10%
==========================================
Files 115 78 -37
Lines 10372 10102 -270
==========================================
- Hits 9880 9613 -267
+ Misses 492 489 -3
Continue to review full report at Codecov.
|
Owner
|
Merged as 6fbb0b8, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll just quote the commit message:
Vector3*I don't know why Khronos would change the link for a deprecated extension, but yeah, current one leads to a 404. It's officially superceded by
KHR_materials_specular, which might be worth supporting sometime in the future.