Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Cgltf,TinyGltf}Importer: doc fixes #114

Closed
wants to merge 1 commit into from

Conversation

pezcode
Copy link
Contributor

@pezcode pezcode commented Oct 30, 2021

I'll just quote the commit message:

  • texture coordinate types were incorrectly documented as Vector3*
  • tangent types were not mentioned
  • KHR_materials_pbrSpecularGlossiness link was moved to Archived

I don't know why Khronos would change the link for a deprecated extension, but yeah, current one leads to a 404. It's officially superceded by KHR_materials_specular, which might be worth supporting sometime in the future.

- texture coordinate types were incorrectly documented as Vector3*
- tangent types were not mentioned
- KHR_materials_pbrSpecularGlossiness link was moved to Archived
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #114 (480c436) into master (809fc18) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   95.25%   95.15%   -0.10%     
==========================================
  Files         115       78      -37     
  Lines       10372    10102     -270     
==========================================
- Hits         9880     9613     -267     
+ Misses        492      489       -3     
Impacted Files Coverage Δ
src/MagnumPlugins/CgltfImporter/CgltfImporter.h 100.00% <ø> (ø)
.../MagnumPlugins/TinyGltfImporter/TinyGltfImporter.h 100.00% <ø> (ø)
src/MagnumPlugins/PngImporter/PngImporter.cpp 94.94% <0.00%> (-1.10%) ⬇️
...MagnumPlugins/Faad2AudioImporter/Faad2Importer.cpp 86.84% <0.00%> (-0.66%) ⬇️
...numPlugins/PngImageConverter/PngImageConverter.cpp 81.42% <0.00%> (-0.52%) ⬇️
src/MagnumPlugins/HarfBuzzFont/HarfBuzzFont.cpp 97.22% <0.00%> (-0.34%) ⬇️
src/MagnumPlugins/FreeTypeFont/FreeTypeFont.cpp 98.64% <0.00%> (-0.15%) ⬇️
src/MagnumPlugins/KtxImporter/KtxImporter.cpp 88.39% <0.00%> (-0.15%) ⬇️
.../StanfordSceneConverter/StanfordSceneConverter.cpp 96.31% <0.00%> (-0.10%) ⬇️
src/MagnumPlugins/IcoImporter/IcoImporter.cpp 95.74% <0.00%> (-0.09%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809fc18...480c436. Read the comment docs.

@mosra mosra added this to the 2021.0a milestone Oct 31, 2021
@mosra mosra added this to TODO in Asset management via automation Oct 31, 2021
@mosra
Copy link
Owner

mosra commented Oct 31, 2021

Merged as 6fbb0b8, thank you!

@mosra mosra closed this Oct 31, 2021
Asset management automation moved this from TODO to Done Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants