Skip to content

modules: Fix FindWebP.cmake for windows #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Squareys
Copy link
Contributor

Hi @mosra !

This is a very simple one, the precompiled binaries on windows are named libwebp.lib and similar, and on Windows, NAMES webp is therefore not enough, since windows has empty CMAKE_STATIC_LIBRARY_PREFIX.

Best,
Jonathan

Signed-off-by: Squareys <squareys@googlemail.com>
@mosra
Copy link
Owner

mosra commented Jul 13, 2022

Ah lol once again Google's "buildsystem" that doesn't care about platform differences and uses a lib prefix everywhere. Thanks!

Annoying request: since you say there's a prebuilt library, could you make this be built on AppVeyor as well? (I won't get mad if you refuse.)

@mosra mosra added this to the 2022.0a milestone Jul 13, 2022
@Squareys
Copy link
Contributor Author

@mosra I did actually try for 15 Minutes, but because they package their prebuilt binaries with an additional folder inside the zip, I got stuck trying to unpack the zip such that the include, lib and bin would get merged into dependencies. Currently unfortunately that meat I had to give up, too much going on atm :/

@mosra
Copy link
Owner

mosra commented Sep 18, 2022

Merged as 36c8af4, and in e28d05b I added the Windows CI build to have this covered there as well. Wasn't too bad in the end :P

@mosra mosra closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants