cmake: fix test build #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a real issue or there's something wrong with my environment? If it's legit, I have a very similar patch for magnum-integration. |
sthalik
force-pushed
the
pr/fix-test-build
branch
from
83fde59 to
4b09ed2
Compare
sthalik
force-pushed
the
pr/fix-test-build
branch
from
4b09ed2 to
e303070
Compare
|
Huh. Yes, it's legit. It doesn't cause issues for me or for the CI because there Magnum is always installed to a global-ish include path that gets pulled in by other dependencies anyway. But that's not the case for e.g. CMake subprojects or when you install each project to its own path.
And all other repos :) I'll commit those fixes myself with your name so you don't need to bother with forking & PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.