New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGexImporter: Fix light import #16

Merged
merged 1 commit into from Aug 29, 2016

Conversation

3 participants
@Squareys
Contributor

Squareys commented Aug 29, 2016

Good morning @mosra ! :)

As discussed, here is the PR that changes the "color" to "light" to match the ogex specs.

Regars, Jonathan.

OpenGexImporter: Change light color attribute from "color" to "light"
Signed-off-by: Squareys <Squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:fix-ogex-light-import branch from 9922246 to f471ddf Aug 29, 2016

@coveralls

This comment has been minimized.

coveralls commented Aug 29, 2016

Coverage Status

Coverage remained the same at 85.348% when pulling f471ddf on Squareys:fix-ogex-light-import into b677f90 on mosra:master.

@coveralls

This comment has been minimized.

coveralls commented Aug 29, 2016

Coverage Status

Coverage remained the same at 85.348% when pulling f471ddf on Squareys:fix-ogex-light-import into b677f90 on mosra:master.

@mosra mosra merged commit f471ddf into mosra:master Aug 29, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 85.348%
Details
@mosra

This comment has been minimized.

Owner

mosra commented Aug 29, 2016

Thanks (and sorry for the mistake).

@Squareys

This comment has been minimized.

Contributor

Squareys commented Aug 29, 2016

No problem, thank you too!

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment