New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StbVorbisAudioImporter: Allow loading of newer channel amounts #22

Merged
merged 2 commits into from Nov 23, 2016

Conversation

3 participants
@ghost

ghost commented Oct 22, 2016

I was planning to do a full rewrite of this plugin, but I can't quite seem to get some of the logic right.
So instead, here's a PR that will allow surround sound audio to be loaded!

@coveralls

This comment has been minimized.

coveralls commented Oct 22, 2016

Coverage Status

Coverage remained the same at 88.296% when pulling 8841680 on Alicemargatroid:stb_vorbis into aff59c8 on mosra:master.

@coveralls

This comment has been minimized.

coveralls commented Oct 22, 2016

Coverage Status

Coverage remained the same at 88.296% when pulling af6aa8e on Alicemargatroid:stb_vorbis into aff59c8 on mosra:master.

@mosra

This comment has been minimized.

Owner

mosra commented Nov 23, 2016

Finally got to this, sorry for the delays.

Cheers for the STB_VORBIS_NO_STDIO! :)

I have some pending work into master, will merge this right after that.

@mosra mosra merged commit af6aa8e into mosra:master Nov 23, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.296%
Details
@mosra

This comment has been minimized.

Owner

mosra commented Nov 23, 2016

Merged. Thank you a lot.

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment