Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to allow building on both Ubuntu 16.04 and 18.04. #44

wants to merge 1 commit into from


Copy link

@matjam matjam commented May 27, 2018

As promised in mosra/magnum#248, here is a PR that will allow builds to work for both Ubuntu 18.04 and 16.04. Note that some of the changes are also to allow the build to work correctly in Launchpad, as it builds from a clean chroot every time dependencies may not be available.

@mosra mosra added this to TODO in Project management via automation May 30, 2018
@mosra mosra added this to the 2018.0c milestone May 30, 2018
Copy link

mosra commented May 31, 2018

Merged in a144681, though without the explicit Corrade dependency (as we discussed on Gitter) -- if it turns out that the dependency is really needed on Launchpad, we can always add it later.

Thanks! :)

@mosra mosra closed this May 31, 2018
Project management automation moved this from TODO to Done May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

2 participants