Repository navigation
Conversation
|
One important thing: the commit message should contain upstream commit ID (or a link to it, ideally) ;) |
|
Looking at https://codecov.io/gh/mosra/magnum-plugins/src/b16dac21cbc2cd9c7b3cb3a94742dfc7b3e83bb1/src/MagnumPlugins/TinyGltfImporter/TinyGltfImporter.cpp#L655, the URI image import doesn't seem to be tested at all, so can't be sure if the update breaks this code path or not. EDIT: dang sorry wrong button, didn't want to close. For the record, the CIs were green before I closed by accident. |
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 67.18% 67.01% -0.17%
==========================================
Files 43 43
Lines 7341 7434 +93
==========================================
+ Hits 4932 4982 +50
- Misses 2409 2452 +43
Continue to review full report at Codecov.
|
Now at syoyo/tinygltf@39abfb5 Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
…iles Signed-off-by: Squareys <squareys@googlemail.com>
b0f8912 to
667a4ae
Compare
|
Thank you! Merged into
|
Hi @mosra !
As discussed per gitter.
(Summary for others: the patches I applied downstream back then seem to be obsolete.)
Cheers, Jonathan.