Skip to content

Basic animation import in glTF#46

Merged
mosra merged 3 commits into
masterfrom
animation
Aug 4, 2018
Merged

Basic animation import in glTF#46
mosra merged 3 commits into
masterfrom
animation

Conversation

@mosra

@mosra mosra commented Jul 25, 2018

Copy link
Copy Markdown
Owner

Depends on mosra/magnum#191. Things to do:

  • Importing separate TRS as such and not as a single transformation matrix
  • Importing node animation data
  • Cubic Hermite Spline import postponed after merge
  • Verifying this on a bunch of real-life glTF models (from experience, having just handcrafted test data was not a good idea at all)
  • remove the animation branch from CI setups after the Magnum part is merged into master

At the moment, this won't cover skinning or morph targets.

@mosra mosra added this to the 2018.0c milestone Jul 25, 2018
@mosra mosra self-assigned this Jul 25, 2018
@mosra mosra changed the title Basic animation import in glTF [WIP] Basic animation import in glTF Jul 25, 2018
mosra added 2 commits July 27, 2018 13:10
Proved to be very useful lately, should be part of the project.
The misleading naming of tinygltf doesn't help with clarity of this
thing.
@codecov-io

codecov-io commented Jul 27, 2018

Copy link
Copy Markdown

Codecov Report

Merging #46 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   88.67%   88.96%   +0.28%     
==========================================
  Files          41       41              
  Lines        4045     4149     +104     
==========================================
+ Hits         3587     3691     +104     
  Misses        458      458
Impacted Files Coverage Δ
.../MagnumPlugins/TinyGltfImporter/TinyGltfImporter.h 100% <ø> (ø) ⬆️
...agnumPlugins/TinyGltfImporter/TinyGltfImporter.cpp 91.94% <100%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0111e...b4bc480. Read the comment docs.

@mosra mosra force-pushed the animation branch 3 times, most recently from b2b9b9d to b4bc480 Compare August 4, 2018 22:37
@mosra mosra merged commit b4bc480 into master Aug 4, 2018
@mosra mosra changed the title [WIP] Basic animation import in glTF Basic animation import in glTF Aug 4, 2018
@mosra

mosra commented Aug 4, 2018

Copy link
Copy Markdown
Owner Author

Merged! 🎉

@mosra mosra deleted the animation branch August 4, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants