Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic animation import in glTF #46

Merged
merged 3 commits into from Aug 4, 2018
Merged

Basic animation import in glTF #46

merged 3 commits into from Aug 4, 2018

Conversation

mosra
Copy link
Owner

@mosra mosra commented Jul 25, 2018

Depends on mosra/magnum#191. Things to do:

  • Importing separate TRS as such and not as a single transformation matrix
  • Importing node animation data
  • Cubic Hermite Spline import postponed after merge
  • Verifying this on a bunch of real-life glTF models (from experience, having just handcrafted test data was not a good idea at all)
  • remove the animation branch from CI setups after the Magnum part is merged into master

At the moment, this won't cover skinning or morph targets.

@mosra mosra added this to the 2018.0c milestone Jul 25, 2018
@mosra mosra self-assigned this Jul 25, 2018
@mosra mosra added this to TODO in Asset management via automation Jul 25, 2018
@mosra mosra changed the title Basic animation import in glTF [WIP] Basic animation import in glTF Jul 25, 2018
Proved to be very useful lately, should be part of the project.
The misleading naming of tinygltf doesn't help with clarity of this
thing.
@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #46 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   88.67%   88.96%   +0.28%     
==========================================
  Files          41       41              
  Lines        4045     4149     +104     
==========================================
+ Hits         3587     3691     +104     
  Misses        458      458
Impacted Files Coverage Δ
.../MagnumPlugins/TinyGltfImporter/TinyGltfImporter.h 100% <ø> (ø) ⬆️
...agnumPlugins/TinyGltfImporter/TinyGltfImporter.cpp 91.94% <100%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0111e...b4bc480. Read the comment docs.

@mosra mosra force-pushed the animation branch 3 times, most recently from b2b9b9d to b4bc480 Compare August 4, 2018 22:37
@mosra mosra merged commit b4bc480 into master Aug 4, 2018
Asset management automation moved this from TODO to Done Aug 4, 2018
@mosra mosra changed the title [WIP] Basic animation import in glTF Basic animation import in glTF Aug 4, 2018
@mosra
Copy link
Owner Author

mosra commented Aug 4, 2018

Merged! 🎉

@mosra mosra deleted the animation branch August 4, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants