New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeType: reset library variable during finalize() #49

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@ffreling
Contributor

ffreling commented Oct 23, 2018

By not resetting the library variable, we can't safely initialize twice FreeType in the lifetime of the application.

@mosra

This comment has been minimized.

Owner

mosra commented Oct 23, 2018

Ugh, sorry, how did I not test this? 🙈

This looks simple enough to still get into 2018.10, I'll write a test case to ensure this never happens again.

@mosra mosra added this to the 2018.10 milestone Oct 23, 2018

@mosra mosra added this to TODO in Asset management via automation Oct 23, 2018

@mosra mosra moved this from TODO to In progress in Asset management Oct 23, 2018

@mosra

This comment has been minimized.

Owner

mosra commented Oct 23, 2018

Merged in a71ad5e, the corresponding test is one commit earlier. Thanks a lot! 👍

@mosra mosra closed this Oct 23, 2018

Asset management automation moved this from In progress to Done Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment