Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package/msys: Add PKGBUILDs. #50

Closed
wants to merge 2 commits into from

Conversation

williamjcm
Copy link
Contributor

And associated .gitattributes file.

Once again, comments and feedback are welcome! While mosra/corrade#56 and mosra/magnum#307 allowed me to do less mistakes this time, there might still be a few issues remaining.

And associated `.gitattributes` file.
Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 💯 💯 ... almost :)

package/msys/.gitattributes Outdated Show resolved Hide resolved
package/msys/magnum-plugins/PKGBUILD Show resolved Hide resolved
Add HarfBuzz to the stable PKGBUILD and fix .gitattributes.
@codecov-io
Copy link

Codecov Report

Merging #50 into master will decrease coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   89.68%   88.53%   -1.15%     
==========================================
  Files          45       45              
  Lines        4487     4205     -282     
==========================================
- Hits         4024     3723     -301     
- Misses        463      482      +19
Impacted Files Coverage Δ
...rc/MagnumPlugins/AssimpImporter/AssimpImporter.cpp 73.06% <0%> (-11.07%) ⬇️
...agnumPlugins/TinyGltfImporter/TinyGltfImporter.cpp 92.18% <0%> (-0.49%) ⬇️
src/Magnum/OpenDdl/Document.h 88.57% <0%> (-0.32%) ⬇️
...mPlugins/JpegImageConverter/JpegImageConverter.cpp 96.1% <0%> (-0.15%) ⬇️
src/Magnum/OpenDdl/OpenDdl.cpp 90.68% <0%> (-0.12%) ⬇️
src/MagnumPlugins/OpenGexImporter/openGexSpec.hpp 100% <0%> (ø) ⬆️
.../MagnumPlugins/OpenGexImporter/OpenGexImporter.cpp 95.86% <0%> (+0.16%) ⬆️
src/MagnumPlugins/DdsImporter/DdsImporter.cpp 78.15% <0%> (+0.16%) ⬆️
src/MagnumPlugins/PngImporter/PngImporter.cpp 74.69% <0%> (+0.28%) ⬆️
...agnumPlugins/StanfordImporter/StanfordImporter.cpp 94.11% <0%> (+0.36%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 711147d...9b66e0d. Read the comment docs.

@williamjcm
Copy link
Contributor Author

Should be good now. 😅

@mosra mosra added this to the 2019.01 milestone Jan 26, 2019
@mosra mosra added this to TODO in Project management via automation Jan 26, 2019
@mosra mosra mentioned this pull request Jan 27, 2019
55 tasks
@mosra
Copy link
Owner

mosra commented Jan 27, 2019

Merged in 294ff83, thank you!

@mosra mosra closed this Jan 27, 2019
Project management automation moved this from TODO to Done Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants