JpegImporter: redirect libjpeg errors to Corrade::Utility::Error#53
Closed
xqms wants to merge 1 commit intomosra:masterfrom
Closed
JpegImporter: redirect libjpeg errors to Corrade::Utility::Error#53xqms wants to merge 1 commit intomosra:masterfrom
xqms wants to merge 1 commit intomosra:masterfrom
Conversation
Owner
|
Hi, thanks a lot! 👍 For some reason this was already done for the Looks like this code path is not tested either. Will merge this later today / tomorrow together with a test case. |
Contributor
Author
Ah ok, didn't see that. That implementation even looks slightly better with an integrated one-line error message, so maybe just take that one ;-) |
Owner
|
Finally merged in ee69e5c. While adding the test cases for proper code coverage I discovered a handful of random bugs in all image importers (the PNG importer, especially) and, 20 commits later, these should be fixed as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm crawling a large dataset with a few faulty JPEGs - which I would like to ignore silently. However,
libjpegerrors are currently directly printed tostderr. This PR redirects them toCorrage::Utility::Error, which can then be redirected by the user to capture any errors that might occur.