New DrMp3AudioImporter plugin using dr_mp3.#60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=========================================
- Coverage 90.72% 90.63% -0.1%
=========================================
Files 47 49 +2
Lines 4205 4238 +33
=========================================
+ Hits 3815 3841 +26
- Misses 390 397 +7
Continue to review full report at Codecov.
|
mosra
left a comment
There was a problem hiding this comment.
I might have made mistakes here and there. 😅
Doesn't seem so, at all :) Code looks great. Could you enable this plugin in all of package/ci (except appveyor-rt.bat and travis-android-arm.sh because those don't have OpenAL) so we can see what the CI says?
Besides that, can you add the plugin to the lists in
doc/building-plugins.doxdoc/cmake-plugins.doxdoc/namespaces.dox(one@direntry)
and, finally, to FindMagnumPlugins.cmake? Search for DrWav to see where it needs to be added, it's three places in that file.
MSVC 2015 needs it.
According to mosra, the rest of the code is no-op if there are no decoded samples.
|
Merged as fe8b709. This was great, thank you a lot! I have to admit I didn't do a hearing test -- I assume you did ;) |
Yeah, I did test with a bunch of audio files on my end. A game's OST, and a few loose files. |
'Tis my first time contributing a plugin, so I might have made mistakes here and there. 😅
Review/feedback welcome!