-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New DrMp3AudioImporter plugin using dr_mp3. #60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=========================================
- Coverage 90.72% 90.63% -0.1%
=========================================
Files 47 49 +2
Lines 4205 4238 +33
=========================================
+ Hits 3815 3841 +26
- Misses 390 397 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have made mistakes here and there. 😅
Doesn't seem so, at all :) Code looks great. Could you enable this plugin in all of package/ci
(except appveyor-rt.bat
and travis-android-arm.sh
because those don't have OpenAL) so we can see what the CI says?
Besides that, can you add the plugin to the lists in
doc/building-plugins.dox
doc/cmake-plugins.dox
doc/namespaces.dox
(one@dir
entry)
and, finally, to FindMagnumPlugins.cmake
? Search for DrWav
to see where it needs to be added, it's three places in that file.
src/MagnumPlugins/DrMp3AudioImporter/Test/DrMp3ImporterTest.cpp
Outdated
Show resolved
Hide resolved
MSVC 2015 needs it.
According to mosra, the rest of the code is no-op if there are no decoded samples.
Merged as fe8b709. This was great, thank you a lot! I have to admit I didn't do a hearing test -- I assume you did ;) |
Yeah, I did test with a bunch of audio files on my end. A game's OST, and a few loose files. |
'Tis my first time contributing a plugin, so I might have made mistakes here and there. 😅
Review/feedback welcome!