Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DrMp3AudioImporter plugin using dr_mp3. #60

Closed
wants to merge 6 commits into from

Conversation

3 participants
@williamjcm
Copy link
Contributor

commented May 24, 2019

'Tis my first time contributing a plugin, so I might have made mistakes here and there. 馃槄

Review/feedback welcome!

@codecov-io

This comment has been minimized.

Copy link

commented May 24, 2019

Codecov Report

Merging #60 into master will decrease coverage by 0.09%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #60     +/-   ##
=========================================
- Coverage   90.72%   90.63%   -0.1%     
=========================================
  Files          47       49      +2     
  Lines        4205     4238     +33     
=========================================
+ Hits         3815     3841     +26     
- Misses        390      397      +7
Impacted Files Coverage 螖
...c/MagnumPlugins/DrMp3AudioImporter/DrMp3Importer.h 100% <100%> (酶)
...MagnumPlugins/DrMp3AudioImporter/DrMp3Importer.cpp 78.12% <78.12%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 335c792...6e362f0. Read the comment docs.

@mosra mosra added this to the 2019.0b milestone May 24, 2019

@mosra mosra added this to TODO in Asset management via automation May 24, 2019

@mosra mosra self-assigned this May 24, 2019

@mosra
Copy link
Owner

left a comment

I might have made mistakes here and there. 馃槄

Doesn't seem so, at all :) Code looks great. Could you enable this plugin in all of package/ci (except appveyor-rt.bat and travis-android-arm.sh because those don't have OpenAL) so we can see what the CI says?

Besides that, can you add the plugin to the lists in

  • doc/building-plugins.dox
  • doc/cmake-plugins.dox
  • doc/namespaces.dox (one @dir entry)

and, finally, to FindMagnumPlugins.cmake? Search for DrWav to see where it needs to be added, it's three places in that file.

williamjcm added some commits May 25, 2019

DrMp3AudioImporter: remove a code branch.
According to mosra, the rest of the code is no-op if there are no
decoded samples.

@mosra mosra referenced this pull request May 25, 2019

Open

Data import/export plugin improvements #146

5 of 33 tasks complete
@mosra

This comment has been minimized.

Copy link
Owner

commented May 25, 2019

Merged as fe8b709. This was great, thank you a lot!

I have to admit I didn't do a hearing test -- I assume you did ;)

@mosra mosra closed this May 25, 2019

Asset management automation moved this from TODO to Done May 25, 2019

@williamjcm

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

I have to admit I didn't do a hearing test -- I assume you did ;)

Yeah, I did test with a bunch of audio files on my end. A game's OST, and a few loose files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.