Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Hi @mosra !
This is the pullrequest for the BasisImporter plugin. The BasisConverter will be in a separate pullrequest.
I will ping you once you can take the first look at it. Big warning: I currently added all of the https://github.com/binomialLLC/basis_universal code with my patch. I am still hoping BinomialLLC/basis_universal#46 or BinomialLLC/basis_universal#11 or maybe BinomialLLC/basis_universal#13 will be fixed/merged/dealt with by the time this pullrequest is ready or the next release that Rich is working on solves linking to it as a library.
If not, we can rediscuss options for how to integrate it best.
@@ Coverage Diff @@ ## master #62 +/- ## ========================================== - Coverage 90.94% 90.79% -0.16% ========================================== Files 49 51 +2 Lines 4240 3898 -342 ========================================== - Hits 3856 3539 -317 + Misses 384 359 -25
@mosra So, there has been zero visible progress on build system / library support in basis_universal since June. With this PR, I just copied the files of my forked repository with the debug iterator level fix into external, but that was just a temporary solution.
How are we going to include basis? I currently don't see a way that doesn't involve our own patched version, but maybe a submodule is a better idea than just copying the files?
I would say we do it similarly as we did with ImGui (finding sources and building through and external CMake script), plus relying on your fork for Windows builds until BinomialLLC/basis_universal#46 gets finally merged. Or is there anything else needed beyond that?
Submodules are problematic since
That submodule concern makes a lot of sense, yes.
Finding the sources via CMake is a good idea, I remember you suggested that before
For windows support, no further code changes. But to build as a library, we will have to add some cmake project. (Theirs just builds the basisu tool.)