Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssimpImporter: fix material loading #64

Closed
wants to merge 1 commit into from

Conversation

@ikalevatykh
Copy link
Contributor

commented Aug 22, 2019

Fix material loading when the material has ambient texture

@mosra mosra added this to the 2019.0b milestone Aug 22, 2019

@mosra mosra added this to TODO in Asset management via automation Aug 22, 2019

@mosra

This comment has been minimized.

Copy link
Owner

commented Aug 22, 2019

Wow, thank you!

Somehow I missed the main case where you would actually want the ambient color to be white. Will merge tomorrow.

@mosra

This comment has been minimized.

Copy link
Owner

commented Aug 24, 2019

Merged in b1102cb and added a regression test case in a23e6f0 (took a while, because Assimp is ... special). Thanks for the fix!

@mosra mosra closed this Aug 24, 2019

Asset management automation moved this from TODO to Done Aug 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.