Skip to content

AssimpImporter: fix material loading#64

Closed
ikalevatykh wants to merge 1 commit into
mosra:masterfrom
ikalevatykh:master
Closed

AssimpImporter: fix material loading#64
ikalevatykh wants to merge 1 commit into
mosra:masterfrom
ikalevatykh:master

Conversation

@ikalevatykh
Copy link
Copy Markdown
Contributor

Fix material loading when the material has ambient texture

@mosra mosra added this to the 2019.0b milestone Aug 22, 2019
@mosra
Copy link
Copy Markdown
Owner

mosra commented Aug 22, 2019

Wow, thank you!

Somehow I missed the main case where you would actually want the ambient color to be white. Will merge tomorrow.

@mosra
Copy link
Copy Markdown
Owner

mosra commented Aug 24, 2019

Merged in b1102cb and added a regression test case in a23e6f0 (took a while, because Assimp is ... special). Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants