BasisImageConverter

[Squareys]

BasisImporter	>BasisImageConverter<	AnyImageImporter/Converter

Hey @mosra !

Here's step 2 of Basis support, based on the basis-importer branch, so will need to rebase once #62 is merged :)

TODOs:

• Fix SEGFAULT on fileData return of doExportData
• Test
  • RGB
  • RGBA
  • Invalid/Failure
• Additional config options?
• [ ] API for config options?
• Enable on CI
  • Travis
  • AppVeyor
  • CI Green
• Disable on all packages
• Documentation
  • License
  • Configuration
  • Add everywhere

[codecov-io]

Codecov Report

Merging #65 into master will decrease coverage by 0.37%.
The diff coverage is 92.56%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   90.99%   90.62%   -0.38%     
==========================================
  Files          51       53       +2     
  Lines        4377     4201     -176     
==========================================
- Hits         3983     3807     -176     
  Misses        394      394

Impacted Files	Coverage Δ
...mPlugins/BasisImageConverter/BasisImageConverter.h	100% <100%> (ø)
...lugins/BasisImageConverter/BasisImageConverter.cpp	92.5% <92.5%> (ø)
...rc/MagnumPlugins/AssimpImporter/AssimpImporter.cpp	83.33% <0%> (-3.17%)	⬇️
...agnumPlugins/TinyGltfImporter/TinyGltfImporter.cpp	92.43% <0%> (-0.47%)	⬇️
src/Magnum/OpenDdl/Document.h	88.57% <0%> (-0.32%)	⬇️
...mPlugins/JpegImageConverter/JpegImageConverter.cpp	96.1% <0%> (-0.15%)	⬇️
src/Magnum/OpenDdl/OpenDdl.cpp	90.64% <0%> (-0.12%)	⬇️
src/MagnumPlugins/FreeTypeFont/FreeTypeFont.cpp	98.73% <0%> (-0.07%)	⬇️
src/MagnumPlugins/OpenGexImporter/openGexSpec.hpp	100% <0%> (ø)	⬆️
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f7357...0f181d8. Read the comment docs.

[Squareys]

Rebased onto next :)

[mosra]

Thank you!

[mosra]

Just check for BasisImporter alone, this error message may be confusing for people who don't know the aliases. Same below.

[Squareys]

But I guess I would check for BasisImporterRGBA8, but just change the error message, right?

[mosra]

If there's BasisImporter and it doesn't provide a BasisImporterRGBA8 alias, then there's something very off and it should blow up (while this would lead to just SKIP) ... so pick the loudest alternative :D

But this is a minor thing, nothing critical.

[Squareys]

Well, not necessarily, could just be compiled out or an older version 🤷‍♂

Not sure what your comment means in practice, shall I remove the RGBA8 prefix from both the skip message and the loadState call?

[mosra]

Yes, remove both.

[Squareys]

@mosra Rebased, let's see what the CIs say!

[mosra]

Merged, thank you! 🎉