BasisImageConverter#65
Merged
Merged
Conversation
2 tasks
Squareys
force-pushed
the
basis-converter
branch
from
11e3a5c to
9247d38
Compare
Squareys
force-pushed
the
basis-converter
branch
from
9247d38 to
6fd3a05
Compare
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 90.99% 90.62% -0.38%
==========================================
Files 51 53 +2
Lines 4377 4201 -176
==========================================
- Hits 3983 3807 -176
Misses 394 394
Continue to review full report at Codecov.
|
Squareys
force-pushed
the
basis-converter
branch
14 times, most recently
from
6d3ff09 to
7f7938f
Compare
Squareys
force-pushed
the
basis-converter
branch
from
7f7938f to
d79157b
Compare
Contributor
Author
|
Rebased onto |
mosra
reviewed
Sep 24, 2019
Squareys
force-pushed
the
basis-converter
branch
from
4284f45 to
d5c0702
Compare
mosra
reviewed
Sep 29, 2019
mosra
force-pushed
the
next
branch
2 times, most recently
from
6a3de47 to
987be5d
Compare
Squareys
force-pushed
the
basis-converter
branch
from
d5c0702 to
337f841
Compare
Squareys
force-pushed
the
basis-converter
branch
from
337f841 to
930fd27
Compare
mosra
reviewed
Oct 1, 2019
| CORRADE_VERIFY(compressedData); | ||
|
|
||
| if(_importerManager.loadState("BasisImporterRGBA8") == PluginManager::LoadState::NotFound) | ||
| CORRADE_SKIP("BasisImporterRGBA8 plugin not found, cannot test"); |
Owner
There was a problem hiding this comment.
Just check for BasisImporter alone, this error message may be confusing for people who don't know the aliases. Same below.
Contributor
Author
There was a problem hiding this comment.
But I guess I would check for BasisImporterRGBA8, but just change the error message, right?
Owner
There was a problem hiding this comment.
If there's BasisImporter and it doesn't provide a BasisImporterRGBA8 alias, then there's something very off and it should blow up (while this would lead to just SKIP) ... so pick the loudest alternative :D
But this is a minor thing, nothing critical.
Contributor
Author
There was a problem hiding this comment.
Well, not necessarily, could just be compiled out or an older version 🤷♂
Not sure what your comment means in practice, shall I remove the RGBA8 prefix from both the skip message and the loadState call?
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
basis-converter
branch
from
5fac7a2 to
c4172ac
Compare
Contributor
Author
|
@mosra Rebased, let's see what the CIs say! |
Squareys
force-pushed
the
basis-converter
branch
4 times, most recently
from
46db66f to
d31cba5
Compare
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
basis-converter
branch
from
d31cba5 to
0f181d8
Compare
Owner
|
Merged, thank you! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @mosra !
Here's step 2 of Basis support, based on the
basis-importerbranch, so will need to rebase once #62 is merged :)TODOs:
doExportData[ ] API for config options?