Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support for all DXGI formats in DdsImporter #67

Open
wants to merge 2 commits into
base: master
from

Conversation

@mosra
Copy link
Owner

mosra commented Sep 22, 2019

This was all fun and games until I tried to open real-world files and realized it doesn't work at all. What needs to be done:

  • crafting proper test files in random compression types (especially varying compressed block size / block data size), because that's currently totally untested
  • building up a "knowledge base" table with compressed block sizes and data sizes for each generic format we have directly in magnum
  • reworking CompressedImage(View|Data) to check against those, similarly to what Image does for pixels already
TODO: this needs a global knowledge about compressed (block) sizes, and
   that needs a lot of work.
@mosra mosra added this to TODO in Asset management via automation Sep 22, 2019
@mosra mosra changed the title Support for all DXGI formats in DdsImporter [WIP] Support for all DXGI formats in DdsImporter Sep 22, 2019
@mosra mosra added this to the 2019.0c milestone Sep 22, 2019
@mosra mosra force-pushed the dds-dxgi-compressed branch from d087733 to bceb318 Sep 23, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 23, 2019

Codecov Report

Merging #67 into master will increase coverage by 0.58%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   90.54%   91.13%   +0.58%     
==========================================
  Files          49       47       -2     
  Lines        3955     4139     +184     
==========================================
+ Hits         3581     3772     +191     
+ Misses        374      367       -7
Impacted Files Coverage Δ
src/MagnumPlugins/DdsImporter/DdsImporter.h 100% <ø> (ø) ⬆️
src/MagnumPlugins/DdsImporter/DdsImporter.cpp 79.14% <71.42%> (+0.98%) ⬆️
...ns/MiniExrImageConverter/MiniExrImageConverter.cpp 95.83% <0%> (-4.17%) ⬇️
...MagnumPlugins/Faad2AudioImporter/Faad2Importer.cpp 87.17% <0%> (-2.83%) ⬇️
...MagnumPlugins/DrMp3AudioImporter/DrMp3Importer.cpp 83.87% <0%> (-2.8%) ⬇️
src/MagnumPlugins/PngImporter/PngImporter.cpp 93.4% <0%> (-2.2%) ⬇️
...ugins/StbVorbisAudioImporter/StbVorbisImporter.cpp 80% <0%> (-2.06%) ⬇️
...gnumPlugins/DrFlacAudioImporter/DrFlacImporter.cpp 67.94% <0%> (-1.79%) ⬇️
src/MagnumPlugins/JpegImporter/JpegImporter.cpp 92.59% <0%> (-1.64%) ⬇️
...agnumPlugins/StbImageImporter/StbImageImporter.cpp 89.13% <0%> (-1.57%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c79c80...bceb318. Read the comment docs.

@mosra mosra referenced this pull request Oct 2, 2019
7 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.