Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FindBasisUniversal search libraries instead of pkgconfig #72

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@Squareys
Copy link
Contributor

Squareys commented Oct 30, 2019

Hi @mosra !

As promised, here's a version of the FindBasisUniversal that works with vcpkg.
I have a maybe unconventional use of find_package_handle_standard_args in there for setting the BasisUniversal_(Encoder|Transcoder_FOUND vars. It causes output when both are found and I'm interested in your judgment whether that is a good trade-off for the more concise code.

Best,
Jonathan

Copy link
Owner

mosra left a comment

Sorry for not replying earlier.

modules/FindBasisUniversal.cmake Outdated Show resolved Hide resolved
modules/FindBasisUniversal.cmake Outdated Show resolved Hide resolved
modules/FindBasisUniversal.cmake Outdated Show resolved Hide resolved
@mosra mosra added this to the 2019.1c milestone Nov 3, 2019
@mosra mosra added this to TODO in Asset management via automation Nov 3, 2019
@Squareys Squareys force-pushed the Squareys:fix-basis-findmodule branch 2 times, most recently from 2d8e018 to 00fc530 Nov 6, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #72 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage      91%   91.15%   +0.15%     
==========================================
  Files          53       53              
  Lines        4480     4025     -455     
==========================================
- Hits         4077     3669     -408     
+ Misses        403      356      -47
Impacted Files Coverage Δ
...rc/MagnumPlugins/AssimpImporter/AssimpImporter.cpp 83.33% <0%> (-3.17%) ⬇️
src/Magnum/OpenDdl/Document.h 88.57% <0%> (-0.32%) ⬇️
...lugins/BasisImageConverter/BasisImageConverter.cpp 91% <0%> (-0.09%) ⬇️
src/MagnumPlugins/FreeTypeFont/FreeTypeFont.cpp 98.73% <0%> (-0.07%) ⬇️
src/Magnum/OpenDdl/Structure.h 96.49% <0%> (-0.07%) ⬇️
src/MagnumPlugins/DdsImporter/DdsImporter.cpp 77.95% <0%> (-0.04%) ⬇️
src/MagnumPlugins/OpenGexImporter/openGexSpec.hpp 100% <0%> (ø) ⬆️
.../MagnumPlugins/OpenGexImporter/OpenGexImporter.cpp 96.2% <0%> (+0.48%) ⬆️
...agnumPlugins/StanfordImporter/StanfordImporter.cpp 94.38% <0%> (+0.63%) ⬆️
src/Magnum/OpenDdl/Implementation/Parsers.cpp 88.13% <0%> (+0.66%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48f9bd...b0b12ff. Read the comment docs.

@Squareys Squareys force-pushed the Squareys:fix-basis-findmodule branch from 00fc530 to b0b12ff Nov 6, 2019
Copy link
Owner

mosra left a comment

i feel like i'm repeating myself a bit too much 😅

modules/FindBasisUniversal.cmake Outdated Show resolved Hide resolved
modules/FindBasisUniversal.cmake Outdated Show resolved Hide resolved
modules/FindBasisUniversal.cmake Outdated Show resolved Hide resolved
Signed-off-by: Squareys <squareys@googlemail.com>
@Squareys Squareys force-pushed the Squareys:fix-basis-findmodule branch from b0b12ff to c2a0546 Nov 6, 2019
@mosra mosra merged commit c2a0546 into mosra:master Nov 6, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing b48f9bd...c2a0546
Details
codecov/project 91% remains the same compared to b48f9bd
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Asset management automation moved this from TODO to Done Nov 6, 2019
@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Nov 6, 2019

All my local tests worked, so merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.