Repository navigation
Make FindBasisUniversal search libraries instead of pkgconfig - #72
Merged
Merged
Conversation
mosra
reviewed
Nov 3, 2019
Squareys
force-pushed
the
fix-basis-findmodule
branch
2 times, most recently
from
November 6, 2019 14:46
2d8e018 to
00fc530
Compare
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 91% 91.15% +0.15%
==========================================
Files 53 53
Lines 4480 4025 -455
==========================================
- Hits 4077 3669 -408
+ Misses 403 356 -47
Continue to review full report at Codecov.
|
Squareys
force-pushed
the
fix-basis-findmodule
branch
from
November 6, 2019 16:42
00fc530 to
b0b12ff
Compare
mosra
requested changes
Nov 6, 2019
mosra
left a comment
Owner
There was a problem hiding this comment.
i feel like i'm repeating myself a bit too much 😅
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
fix-basis-findmodule
branch
from
November 6, 2019 17:47
b0b12ff to
c2a0546
Compare
Owner
|
All my local tests worked, so merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mosra !
As promised, here's a version of the FindBasisUniversal that works with vcpkg.
I have a maybe unconventional use of
find_package_handle_standard_argsin there for setting theBasisUniversal_(Encoder|Transcoder_FOUNDvars. It causes output when both are found and I'm interested in your judgment whether that is a good trade-off for the more concise code.Best,
Jonathan