-
Notifications
You must be signed in to change notification settings - Fork 62
Make FindBasisUniversal search libraries instead of pkgconfig #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not replying earlier.
2d8e018
to
00fc530
Compare
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 91% 91.15% +0.15%
==========================================
Files 53 53
Lines 4480 4025 -455
==========================================
- Hits 4077 3669 -408
+ Misses 403 356 -47
Continue to review full report at Codecov.
|
00fc530
to
b0b12ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel like i'm repeating myself a bit too much 😅
Signed-off-by: Squareys <squareys@googlemail.com>
b0b12ff
to
c2a0546
Compare
All my local tests worked, so merged, thank you! |
Hi @mosra !
As promised, here's a version of the FindBasisUniversal that works with vcpkg.
I have a maybe unconventional use of
find_package_handle_standard_args
in there for setting theBasisUniversal_(Encoder|Transcoder_FOUND
vars. It causes output when both are found and I'm interested in your judgment whether that is a good trade-off for the more concise code.Best,
Jonathan