Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Vorbis/Ogg Importer based on stb_vorbis #8
Hi @mosra !
Stb is really something, this went pretty quick! The importer only supports 16 bit mono/stereo, no streaming, but here is ogg files support for magnum.
stb_vorbis could also support float data, which will have to wait until
It would be awesome if you could have a quick look at this (it's basically only 10 lines of code or so, everything else is pretty much identical to the wav importer).
One important thing re the naming -- the class and file names are okay, it's
Alright, everything fixed for CIs, which build properly now. A thing I think might be worth mentioning: I had weird errors on all the CIs, invalid pointers or whatever.
First I thought they were caused by the custom deleter possibly not being moved in the array move constructor, but in the end moving the creation of the decoded data array, after checking for sample counts of
All in all, this is ready for merge from my side once again :)