Material texture layer support for TinyGltfImporter and AssimpImporter - #83
Conversation
Just FYI I don't think you need both, just gltf alone is simple (and you can cut that part out of the For Assimp I'm afraid a glTF won't work (at least not on the ass-old versions on the CI), but copying and modifying one of COLLADA files could be easy enough I hope. |
45f3e2b to
b0e4b15
Compare
| CORRADE_COMPARE(mat.diffuseCoordinateSet(), 2); | ||
| CORRADE_COMPARE(mat.ambientCoordinateSet(), 3); | ||
| CORRADE_COMPARE(mat.normalCoordinateSet(), 2); | ||
| } |
There was a problem hiding this comment.
Same as in case of the TinyGltf test -- ideally two variants, testing that the default behavior correctly fails. This also means you need to have three four different materials in order to verify each of the diffuse/specular/ambient/normal failures is done correctly. Instanced tests might (or might not) be helpful.
(What about a specular texture here?)
There was a problem hiding this comment.
I actually solved this before reading your comment... the second ambient should have been specular (copy pasta), and the failure is now also tested, but not separate. Maybe check really quick if the new version satisfies your requirements :)
a31f68c to
513abec
Compare
513abec to
70731c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 93.44% 93.20% -0.25%
==========================================
Files 81 81
Lines 5496 5532 +36
==========================================
+ Hits 5136 5156 +20
- Misses 360 376 +16
Continue to review full report at Codecov.
|
|
@mosra FYI, this is ready and I'm currently waiting for feedback on this :) |
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
70731c8 to
4afa57c
Compare
|
Thx! |
Hi @mosra !
Here's the accompanying PR for mosra/magnum#438.
TODOs: