[StanfordImporter] Support vertex_index for face list #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assimp at least exports ply files with faces as `property list uchar int vertex_index` whereas the code here supports only `vertex_indices` as a name (assimp parses both). The ostensible (PLY reference) http://paulbourke.net/dataformats/ply/ seems to conflate them, implying to me it was silently changed at some point. This change adds support for both.
|
Oh! Thank you. Didn't run into this when verifying with my own model zoo :) Will adapt the tests a bit and merge. |
|
Thank you, merged! Took a while as I had to solve the sudden clang-cl build failure as well, everything should be green on |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assimp (at least) exports ply files with faces as
property list uchar int vertex_indexwhereas the code here supports onlyvertex_indicesas a name (assimp parses both). The ostensible PLY reference seems to conflate them, implying to me it was silently changed at some point. This change adds support for both.