BasisImporter: Initialize state and default configuration for direct use #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosra
reviewed
Apr 5, 2021
Comment on lines
141
to
143
| BasisImporter::BasisImporter() { | ||
| /* Initializes codebook */ | ||
| _state.reset(new State); |
There was a problem hiding this comment.
Suggested change
| BasisImporter::BasisImporter() { | |
| /* Initializes codebook */ | |
| _state.reset(new State); | |
| BasisImporter::BasisImporter(): _state{Containers::InPlaceInit} { |
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
basis-direct-use
branch
from
73cf302 to
d1d27b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
- Coverage 94.15% 94.12% -0.03%
==========================================
Files 95 95
Lines 7062 7064 +2
==========================================
Hits 6649 6649
- Misses 413 415 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mosra As discussed via gitter!
The
BasisImporterdefault constructor was not initializing its state, preventing direct use throughBasisImporter::initialize(); BasisImporter importer;Best,
Jonathan