Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasisImporter: Initialize state and default configuration for direct use #96

Merged
merged 1 commit into from Apr 5, 2021

Conversation

Squareys
Copy link
Contributor

@Squareys Squareys commented Apr 5, 2021

@mosra As discussed via gitter!

The BasisImporter default constructor was not initializing its state, preventing direct use through

BasisImporter::initialize();
BasisImporter importer;

Best,
Jonathan

Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the CI is failing 😆

Comment on lines 141 to 143
BasisImporter::BasisImporter() {
/* Initializes codebook */
_state.reset(new State);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BasisImporter::BasisImporter() {
/* Initializes codebook */
_state.reset(new State);
BasisImporter::BasisImporter(): _state{Containers::InPlaceInit} {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very fancy :D

Signed-off-by: Squareys <squareys@googlemail.com>
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #96 (d1d27b0) into master (410e388) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   94.15%   94.12%   -0.03%     
==========================================
  Files          95       95              
  Lines        7062     7064       +2     
==========================================
  Hits         6649     6649              
- Misses        413      415       +2     
Impacted Files Coverage Δ
src/MagnumPlugins/BasisImporter/BasisImporter.cpp 88.97% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410e388...d1d27b0. Read the comment docs.

@mosra mosra added this to the 2020.0b milestone Apr 5, 2021
@mosra mosra added this to TODO in Asset management via automation Apr 5, 2021
@mosra mosra merged commit d1d27b0 into mosra:master Apr 5, 2021
Asset management automation moved this from TODO to Done Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants