TinyGltfImporter: Update docs about animation #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 101 101
Lines 7257 7257
=======================================
Hits 6868 6868
Misses 389 389
Continue to review full report at Codecov.
|
mosra
reviewed
Jun 24, 2021
| @@ -131,7 +131,7 @@ calls with @ref InputFileCallbackPolicy::LoadTemporary and | |||
| @ref InputFileCallbackPolicy::Close is emitted right after the file is fully | |||
| read. | |||
|
|
|||
| Import of skeleton, skin and morph data is not supported at the moment. | |||
| Import of skeleton and morph data is not supported at the moment. | |||
There was a problem hiding this comment.
I removed the "skeleton" from here as well and merged as f9e41c6. This was originally here only because I had very little idea about what's the difference between a skin and a skeleton, and given that it's just a single ID that (apparently) almost nobody uses, I don't think it needs to be mentioned here.
Thanks for the PR! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these two small fixes while comparing what to copy over to
AssimpImporter. Skin data seems to be imported, and the importer state forAnimationDatawasn't being mentioned.