Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyGltfImporter: Update docs about animation #98

wants to merge 1 commit into from


Copy link

@pezcode pezcode commented Jun 20, 2021

Found these two small fixes while comparing what to copy over to AssimpImporter. Skin data seems to be imported, and the importer state for AnimationData wasn't being mentioned.

Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #98 (5851343) into master (03d6ac6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
  Coverage   94.63%   94.63%           
  Files         101      101           
  Lines        7257     7257           
  Hits         6868     6868           
  Misses        389      389           
Impacted Files Coverage Δ
.../MagnumPlugins/TinyGltfImporter/TinyGltfImporter.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d6ac6...5851343. Read the comment docs.

@mosra mosra added this to TODO in Asset management via automation Jun 24, 2021
@mosra mosra added this to the 2021.0a milestone Jun 24, 2021
@@ -131,7 +131,7 @@ calls with @ref InputFileCallbackPolicy::LoadTemporary and
@ref InputFileCallbackPolicy::Close is emitted right after the file is fully

Import of skeleton, skin and morph data is not supported at the moment.
Import of skeleton and morph data is not supported at the moment.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the "skeleton" from here as well and merged as f9e41c6. This was originally here only because I had very little idea about what's the difference between a skin and a skeleton, and given that it's just a single ID that (apparently) almost nobody uses, I don't think it needs to be mentioned here.

Thanks for the PR! 👍

@mosra mosra closed this Jun 24, 2021
Asset management automation moved this from TODO to Done Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants