Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attachCubeMapTexture issue #123

Closed
chpatrick opened this issue Nov 26, 2015 · 3 comments
Closed

attachCubeMapTexture issue #123

chpatrick opened this issue Nov 26, 2015 · 3 comments

Comments

@chpatrick
Copy link

@chpatrick chpatrick commented Nov 26, 2015

I'm trying to use Framebuffer::attachCubeMapTexture to attach a face of a cubemap, but in my apitrace I see that it calls glNamedFramebufferTexture, without specifying the appropriate texture target. My guess is that it's because it picks texture2DImplementationDSA, which doesn't seem appropriate in this situation.

@mosra
Copy link
Owner

@mosra mosra commented Nov 29, 2015

Hi, sorry, somehow completely missed this one (GitHub is not sending e-mails about new issues, aargh). I guess it should call glNamedFramebufferTextureLayer(), right? Will look into it right now.

@mosra mosra added the bug label Nov 29, 2015
@mosra
Copy link
Owner

@mosra mosra commented Nov 29, 2015

Should be fixed in 291b5bd, please reopen if there are any other problems.

As a side note I now understand what layered attachments are (and why it didn't report any GL error), so I should be able to implement support for these now as well.

@mosra mosra closed this Nov 29, 2015
@mosra
Copy link
Owner

@mosra mosra commented Nov 29, 2015

Layered attachments done in 3d9d70f.

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants